Shawn Pearce 7569b30f60 Micro-optimize InternalGroupBackend.handles ...

UniversalGroupBackend passes every AccountGroup.UUID to every
GroupBackend.handles(), and InternalGroupBackend ran a regex
to see if it should respond for the UUID.

This method running a regex using String.matches(pattern) can
be the source of 1% of the garbage for a very busy Gerrit server
performing a lot of ACL evaluation.

As internal groups are SHA-1 hex shape (for reasons like this)
rely on JGit's optimized ObjectId.isId() to test the shape of
the UUID.

Change-Id: I13864886b447dbf81bafb793695367b5f0d15fb4

2016-06-19 14:00:08 -04:00

..

AbstractGroupBackend.java

Revert "Perform user.getEffectiveGroups() less eagerly"

2015-02-17 17:16:33 -08:00

AbstractRealm.java

Make email validation case insensitive

2015-11-12 16:54:49 +00:00

AccountByEmailCache.java

Remove modifiers 'public' and 'abstract' from interface methods

2015-11-19 09:36:40 -08:00

AccountByEmailCacheImpl.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

AccountCache.java

Remove modifiers 'public' and 'abstract' from interface methods

2015-11-19 09:36:40 -08:00

AccountCacheImpl.java

Replace AccountGeneralPreferences entity with git backend (phase 2)

2016-02-18 10:31:07 +00:00

AccountControl.java

Convert CurrentUser to IdentifiedUser without casting

2015-10-19 11:49:10 -04:00

AccountDirectory.java

Remove unnecessary semicolons in enum declarations

2015-05-17 13:48:49 +02:00

AccountException.java

…

AccountInfoCacheFactory.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

AccountLoader.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

AccountManager.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

AccountResolver.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

AccountResource.java

Support star labels

2016-05-06 17:04:47 +02:00

AccountsCollection.java

Add missing whitespace around keywords, operators and braces

2016-04-11 19:51:18 +09:00

AccountState.java

CurrentUser.PropertyKey<T>: allow plugins to cache data on users

2016-05-15 22:21:36 -07:00

AccountUserNameException.java

…

AccountVisibility.java

Remove unnecessary semicolons

2013-11-10 05:44:17 +04:00

AccountVisibilityProvider.java

AccountVisibilityProvider: Remove support for legacy suggest.accounts

2016-02-18 17:59:45 +09:00

AddSshKey.java

Store SSH keys in git

2016-05-02 20:46:54 +02:00

AuthenticationFailedException.java

Organize imports

2015-08-20 11:29:39 +09:00

AuthorizedKeys.java

Store SSH keys in git

2016-05-02 20:46:54 +02:00

AuthRequest.java

Organize imports

2015-12-16 16:19:57 -05:00

AuthResult.java

…

Capabilities.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

CapabilityCollection.java

Enable configurable 'maxBatchChanges' limit

2014-11-20 19:01:14 +00:00

CapabilityControl.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

CapabilityUtils.java

SSH: Don't use providers in commands

2016-04-18 20:03:19 +00:00

ChangeUserName.java

Move InvalidUserNameException to com.google.gerrit.server.account

2016-02-18 17:59:45 +09:00

CreateAccount.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

CreateEmail.java

Remove redundant 'static' modifiers

2016-04-11 20:24:44 +09:00

CreateGroupArgs.java

Remove support for initial groups from PerformCreateGroup

2015-04-09 07:44:59 +00:00

DefaultRealm.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

DeleteActive.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

DeleteEmail.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

DeleteSshKey.java

Store SSH keys in git

2016-05-02 20:46:54 +02:00

DeleteWatchedProjects.java

Make watched.projects:delete respect the filter

2016-05-30 17:03:07 +02:00

EmailExpander.java

Remove redundant modifiers from interfaces' methods

2016-04-12 21:44:27 +09:00

Emails.java

Add hasEmailAddress to IdentifiedUser

2014-12-19 16:01:24 -08:00

FakeRealm.java

Remove unneeded link and unlink methods from Realm

2016-05-09 11:43:58 +02:00

GeneralPreferencesLoader.java

Replace AccountGeneralPreferences entity with git backend (phase 2)

2016-02-18 10:31:07 +00:00

GetAccount.java

Replace account.AccountInfo with extensions.common.AccountInfo

2014-11-26 11:44:56 -05:00

GetActive.java

Move REST endpoints to singleton scope

2014-05-28 16:33:12 -07:00

GetAvatar.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

GetAvatarChangeUrl.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

GetCapabilities.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

GetDetail.java

Remove contact store functionality

2015-08-28 14:08:58 -04:00

GetDiffPreferences.java

Make diff preferences defaults configurable

2016-05-19 09:23:58 +02:00

GetEditPreferences.java

Add missing newline at end of files

2016-05-04 13:48:11 +00:00

GetEmail.java

Get{Email|Username}: Add back empty @Inject constructors

2016-01-14 10:57:12 +09:00

GetEmails.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

GetGroups.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

GetHttpPassword.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

GetName.java

Move REST endpoints to singleton scope

2014-05-28 16:33:12 -07:00

GetOAuthToken.java

REST API for retrieving OAuth access tokens

2016-05-10 13:47:34 +02:00

GetPreferences.java

SetPreferences/GetPreferences: Remove unused exception declarations

2016-03-20 10:48:40 +00:00

GetSshKey.java

Extract SshKeyInfo from GetSshKeys to extension API

2016-03-16 19:14:53 +09:00

GetSshKeys.java

Store SSH keys in git

2016-05-02 20:46:54 +02:00

GetUsername.java

Get{Email|Username}: Add back empty @Inject constructors

2016-01-14 10:57:12 +09:00

GetWatchedProjects.java

Implemented GET endpoint for watched projects

2016-05-04 09:32:19 +02:00

GroupBackend.java

Revert "Perform user.getEffectiveGroups() less eagerly"

2015-02-17 17:16:33 -08:00

GroupBackends.java

Miscellaneous Javadoc cleanups to cut down on Eclipse warnings

2013-10-09 12:18:31 -07:00

GroupCache.java

Remove modifiers 'public' and 'abstract' from interface methods

2015-11-19 09:36:40 -08:00

GroupCacheImpl.java

Add missing whitespace around keywords, operators and braces

2016-04-11 19:51:18 +09:00

GroupComparator.java

…

GroupControl.java

Convert CurrentUser to IdentifiedUser without casting

2015-10-19 11:49:10 -04:00

GroupDetailFactory.java

GroupDetailFactory: Remove unnecessary 'final' modifiers

2016-05-12 15:12:29 +09:00

GroupIncludeCache.java

Remove modifiers 'public' and 'abstract' from interface methods

2015-11-19 09:36:40 -08:00

GroupIncludeCacheImpl.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

GroupMembers.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

GroupMembership.java

Fix buck build api errors

2016-05-10 12:56:33 -07:00

GroupUUID.java

…

IncludingGroupMembership.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

InternalAccountDirectory.java

Include 32px and 100px avatar URLs

2016-05-15 21:18:19 -07:00

InternalGroupBackend.java

Micro-optimize InternalGroupBackend.handles

2016-06-19 14:00:08 -04:00

InvalidUserNameException.java

Move InvalidUserNameException to com.google.gerrit.server.account

2016-02-18 17:59:45 +09:00

ListGroupMembership.java

…

Module.java

Merge changes I4fad66f5,I6ddb8258

2016-06-14 14:33:51 +00:00

PostWatchedProjects.java

Added DELETE/POST endpoint for watched projects

2016-05-06 06:20:47 +00:00

PutAccount.java

Move REST endpoints to singleton scope

2014-05-28 16:33:12 -07:00

PutActive.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

PutEmail.java

Move CreateEmail.Input to EmailInput in extension API

2015-05-28 16:05:40 +09:00

PutHttpPassword.java

Merge "Fix error message when setting HTTP password is not allowed"

2015-06-18 07:21:19 +00:00

PutName.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

PutPreferred.java

Revert "Use javax.inject.Inject instead of com.google.inject.Inject"

2014-09-30 10:53:50 +02:00

PutUsername.java

Enable and fix 'Statement unnecessarily nested within else clause' warnings

2016-06-02 10:20:37 +09:00

Realm.java

Remove unneeded link and unlink methods from Realm

2016-05-09 11:43:58 +02:00

SetDiffPreferences.java

AccountApi: Add methods to get and set DiffPreferencesInfo

2016-04-05 08:37:38 +02:00

SetEditPreferences.java

SetEditPreferences: Return info from REST handler

2016-04-05 08:34:03 +02:00

SetPreferences.java

Clean up REST API: server config SetPreferences

2016-05-02 16:14:23 -05:00

SshKeys.java

Store SSH keys in git

2016-05-02 20:46:54 +02:00

StarredChanges.java

Support star labels

2016-05-06 17:04:47 +02:00

Stars.java

Support star labels

2016-05-06 17:04:47 +02:00

SuggestAccounts.java

Factor out an AccountInfoComparator class to avoid code duplication

2015-11-12 19:16:06 -08:00

UniversalGroupBackend.java

Use native constructors instead of Guava to instantiate empty collections

2016-05-04 22:41:39 +09:00

VersionedAccountDestinations.java

Organize imports

2015-09-10 11:25:57 -04:00

VersionedAccountPreferences.java

DiffPreferencesIT: Add test for configured default values

2016-06-03 15:08:50 +02:00

VersionedAccountQueries.java

Remove unused imports

2015-09-02 10:22:43 +09:00

VersionedAuthorizedKeys.java

Clean up various CheckStyle warnings

2016-05-17 15:07:30 +09:00