Files
gerrit/polygerrit-ui/app/elements/plugins/gr-endpoint-param/gr-endpoint-param.js
Dmitrii Filippov d108bdc4cc Fix problem with {property}-changed event
In polymer 2 the following change was made:
Property change notifications (property-changed events) aren't fired when
the value changes as a result of a binding from the host
(see https://polymer-library.polymer-project.org/2.0/docs/about_20).
The polymer team suggested to use observer instead of {property}-changed
event.

Bug: Issue 11316
Change-Id: I12d1860d3ee836724c111605725d806687ec2141
2019-08-14 13:00:26 +02:00

48 lines
1.5 KiB
JavaScript

/**
* @license
* Copyright (C) 2017 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
(function() {
'use strict';
Polymer({
is: 'gr-endpoint-param',
_legacyUndefinedCheck: true,
properties: {
name: String,
value: {
type: Object,
notify: true,
observer: '_valueChanged',
},
},
_valueChanged(newValue, oldValue) {
/* In polymer 2 the following change was made:
"Property change notifications (property-changed events) aren't fired when
the value changes as a result of a binding from the host"
(see https://polymer-library.polymer-project.org/2.0/docs/about_20).
To workaround this problem, we fire the event from the observer.
In some cases this fire the event twice, but our code is
ready for it.
*/
const detail = {
value: newValue,
};
this.dispatchEvent(new CustomEvent('value-changed', {detail}));
},
});
})();