Files
gerrit/polygerrit-ui/app/behaviors/rest-client-behavior/rest-client-behavior.html
Kasper Nilsson f73f8cf663 Make mergeable check more explicit
The 'mergeable' property of a change exists only if it is specifically
asked for, otherwise it is undefined. This was causing some false
positives when checking for merge conflicts.

Also removes some dead code.

Bug: Issue 6819
Change-Id: Ib42bac8067afacb09d20cd122f9d9f41425207e0
2017-07-21 16:56:19 -07:00

143 lines
3.9 KiB
HTML

<!--
Copyright (C) 2016 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import" href="../../bower_components/polymer/polymer.html">
<link rel="import" href="../base-url-behavior/base-url-behavior.html">
<script>
(function(window) {
'use strict';
/** @polymerBehavior Gerrit.RESTClientBehavior */
const RESTClientBehavior = {
ChangeDiffType: {
ADDED: 'ADDED',
COPIED: 'COPIED',
DELETED: 'DELETED',
MODIFIED: 'MODIFIED',
RENAMED: 'RENAMED',
REWRITE: 'REWRITE',
},
ChangeStatus: {
ABANDONED: 'ABANDONED',
DRAFT: 'DRAFT',
MERGED: 'MERGED',
NEW: 'NEW',
},
// Must be kept in sync with the ListChangesOption enum and protobuf.
ListChangesOption: {
LABELS: 0,
DETAILED_LABELS: 8,
// Return information on the current patch set of the change.
CURRENT_REVISION: 1,
ALL_REVISIONS: 2,
// If revisions are included, parse the commit object.
CURRENT_COMMIT: 3,
ALL_COMMITS: 4,
// If a patch set is included, include the files of the patch set.
CURRENT_FILES: 5,
ALL_FILES: 6,
// If accounts are included, include detailed account info.
DETAILED_ACCOUNTS: 7,
// Include messages associated with the change.
MESSAGES: 9,
// Include allowed actions client could perform.
CURRENT_ACTIONS: 10,
// Set the reviewed boolean for the caller.
REVIEWED: 11,
// Include download commands for the caller.
DOWNLOAD_COMMANDS: 13,
// Include patch set weblinks.
WEB_LINKS: 14,
// Include consistency check results.
CHECK: 15,
// Include allowed change actions client could perform.
CHANGE_ACTIONS: 16,
// Include a copy of commit messages including review footers.
COMMIT_FOOTERS: 17,
// Include push certificate information along with any patch sets.
PUSH_CERTIFICATES: 18,
// Include change's reviewer updates.
REVIEWER_UPDATES: 19,
// Set the submittable boolean.
SUBMITTABLE: 20,
},
listChangesOptionsToHex(...args) {
let v = 0;
for (let i = 0; i < args.length; i++) {
v |= 1 << args[i];
}
return v.toString(16);
},
changeBaseURL(changeNum, patchNum) {
let v = this.getBaseUrl() + '/changes/' + changeNum;
if (patchNum) {
v += '/revisions/' + patchNum;
}
return v;
},
changePath(changeNum) {
return this.getBaseUrl() + '/c/' + changeNum;
},
changeIsOpen(status) {
return status === this.ChangeStatus.NEW ||
status === this.ChangeStatus.DRAFT;
},
changeStatusString(change) {
const states = [];
if (change.status === this.ChangeStatus.MERGED) {
states.push('Merged');
} else if (change.status === this.ChangeStatus.ABANDONED) {
states.push('Abandoned');
} else if (change.mergeable === false) {
// 'mergeable' prop may not always exist (@see Issue 6819)
states.push('Merge Conflict');
}
if (change.work_in_progress) { states.push('WIP'); }
if (change.is_private) { states.push('Private'); }
if (change.status === this.ChangeStatus.DRAFT) { states.push('Draft'); }
return states.join(', ');
},
};
window.Gerrit = window.Gerrit || {};
window.Gerrit.RESTClientBehavior = [
Gerrit.BaseUrlBehavior,
RESTClientBehavior,
];
})(window);
</script>