4f10d777d9
As of M80(chrome version >= 80), chrome removed the native htmlImports support, tho we have the polyfill from webcomponents, the loading of html changed from sync to async which cause a lot test to fail in M80. The fix is introducing a util method `readyToTest` which wait until htmlImports finished before running any tests. Updated some tests to have only one top suite per test so we only need one `readyToTest` and also multiple `readyToTest` actually affect tests' stub functionality. Tested locally with `npm run test` on all passed tests and also with manual failure to make sure the updated tests can still catch any errors if have. Bug: Issue 12294 Change-Id: Ib0c464f8ff9f36a401e6c3b249e6bb6d68ee6e2f
90 lines
2.8 KiB
HTML
90 lines
2.8 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
@license
|
|
Copyright (C) 2018 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-diff-mode-selector</title>
|
|
|
|
<script src="/bower_components/webcomponentsjs/custom-elements-es5-adapter.js"></script>
|
|
|
|
<script src="/bower_components/webcomponentsjs/webcomponents-lite.js"></script>
|
|
<script src="/bower_components/web-component-tester/browser.js"></script>
|
|
<script src="../../../test/test-pre-setup.js"></script>
|
|
<link rel="import" href="../../../test/common-test-setup.html"/>
|
|
<script src="/bower_components/page/page.js"></script>
|
|
<script src="../../../scripts/util.js"></script>
|
|
|
|
<link rel="import" href="gr-diff-mode-selector.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-diff-mode-selector></gr-diff-mode-selector>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-diff-mode-selector tests', async () => {
|
|
await readyToTest();
|
|
let element;
|
|
let sandbox;
|
|
|
|
setup(() => {
|
|
sandbox = sinon.sandbox.create();
|
|
element = fixture('basic');
|
|
});
|
|
|
|
teardown(() => {
|
|
sandbox.restore();
|
|
});
|
|
|
|
test('_computeSelectedClass', () => {
|
|
assert.equal(
|
|
element._computeSelectedClass('SIDE_BY_SIDE', 'SIDE_BY_SIDE'),
|
|
'selected');
|
|
assert.equal(
|
|
element._computeSelectedClass('SIDE_BY_SIDE', 'UNIFIED_DIFF'), '');
|
|
});
|
|
|
|
test('setMode', () => {
|
|
const saveStub = sandbox.stub(element.$.restAPI, 'savePreferences');
|
|
|
|
// Setting the mode initially does not save prefs.
|
|
element.saveOnChange = true;
|
|
element.setMode('SIDE_BY_SIDE');
|
|
assert.isFalse(saveStub.called);
|
|
|
|
// Setting the mode to itself does not save prefs.
|
|
element.setMode('SIDE_BY_SIDE');
|
|
assert.isFalse(saveStub.called);
|
|
|
|
// Setting the mode to something else does not save prefs if saveOnChange
|
|
// is false.
|
|
element.saveOnChange = false;
|
|
element.setMode('UNIFIED_DIFF');
|
|
assert.isFalse(saveStub.called);
|
|
|
|
// Setting the mode to something else does not save prefs if saveOnChange
|
|
// is false.
|
|
element.saveOnChange = true;
|
|
element.setMode('SIDE_BY_SIDE');
|
|
assert.isTrue(saveStub.calledOnce);
|
|
});
|
|
});
|
|
</script>
|