c89c21cd6d
ChangeNotes.Factory now loads the change from the database. This should become the only place where changes are loaded from the database, but for this more work is required in follow-up changes. We need to load the change for the database also when notedb is enabled. This is because for now we still want to write updates to the database when notedb is enabled. In order to write update to the database the change instance must be created by loading it from the database because otherwise its row version is not set and then all updates to the database fail with OrmConcurrencyException. The signature of the ChangeNotes.Factory#create is changed to require project name and a change ID instead of a change. Project name is not needed yet, since the change is always loaded by change ID from the database, but later when reviewdb is gone we will need the project name to instantiate the change from notedb. For changes that have been loaded from the secondary index we don't want to reload them from the database. This is why a new ChangeNotes.Factory#createFromIndexedChange method is added that still takes a change as input. Change-Id: Idc274d6938f989b4d7fa49ee496d7ac84c749455 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.
Events
- March 14-18 2016: Gerrit Hackathon, Berlin (free seats are still available).