c8e96ad49d
If a screen is registered by a plugin this registration needs to be completed before the dispatcher tries to parse the token. Wait for plugin scripts to finish loading and evaluating. The old method of injecting a script tag was not waiting correctly, especially for GWT based plugins. JavaScript plugins are now required to use Gerrit.install() as this method updates internal Gerrit state tracking the script. Not using install() will eventually cause the UI to report the plugin as failing to load. GWT plugins must override onPluginLoad() not onModuleLoad(). All plugins must recompile with the new glue code, as there is now a handshake between the GWT plugin and the main Gerrit code. All plugins must load within 5 seconds, otherwise the page marks them as failed and reports loading errors. During loading a glass pane is used to prevent the user from interacting with a partial initialized UI. Plugins may be making critical contributions that need to be registered before use. A chunk of the API glue code was moved around to make each JSNI block smaller, and better isolate purpose. Plugin is now declared in its own Java class. Plugin instances are now tracked in the map $wnd.Gerrit.plugins. This allows the main code to later figure out if any instance failed to load. Any loading errors are usually reported on the JavaScript console as script failures, and may include stack traces. Change-Id: Id03581437ae1010cf995ef7ba8626ece37dfc2f4
If you are adding a directory here: - Search all pom.xml files for "CORE PLUGIN LIST". - Add the new plugin to that location. - (optional) Thank the Maven developers for making this easy. - Ensure the plugin's pom.xml <version> is the same as Gerrit's own pom.xml(s). Gerrit will only embed a plugin that has the same version as itself. - Register the plugin as a submodule with git submodule.