Files
gerrit/polygerrit-ui/app/behaviors/gr-change-table-behavior/gr-change-table-behavior.html
Wyatt Allen 3b5ae7518d Handle legacy name in change_table preferences
After updating the "Project" column name to "Repo", there were still
references to the former name in the change_table preference, which
controls what columns appear in the change table. Because, following the
rename, preferences would have an outdated key, this had the unintended
effect of hiding the repo column by default for any user who had
modified that preference.

With this change, the appearance of "Project" in a change_table list is
treated like an appearance of "Repo".

Bug: Issue 9509
Change-Id: I1e773b5dd07dd086551f62aacbbe5973078e9ee4
2018-08-01 16:11:23 -07:00

80 lines
2.2 KiB
HTML

<!--
@license
Copyright (C) 2016 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<script>
(function(window) {
'use strict';
window.Gerrit = window.Gerrit || {};
/** @polymerBehavior Gerrit.ChangeTableBehavior */
Gerrit.ChangeTableBehavior = {
properties: {
columnNames: {
type: Array,
value: [
'Subject',
'Status',
'Owner',
'Assignee',
'Repo',
'Branch',
'Updated',
'Size',
],
readOnly: true,
},
},
/**
* Returns the complement to the given column array
* @param {Array} columns
* @return {!Array}
*/
getComplementColumns(columns) {
return this.columnNames.filter(column => {
return !columns.includes(column);
});
},
/**
* @param {string} columnToCheck
* @param {!Array} columnsToDisplay
* @return {boolean}
*/
isColumnHidden(columnToCheck, columnsToDisplay) {
return !columnsToDisplay.includes(columnToCheck);
},
/**
* The Project column was renamed to Repo, but some users may have
* preferences that use its old name. If that column is found, rename it
* before use.
* @param {!Array<string>} columns
* @return {!Array<string>} If the column was renamed, returns a new array
* with the corrected name. Otherwise, it returns the original param.
*/
getVisibleColumns(columns) {
const projectIndex = columns.indexOf('Project');
if (projectIndex === -1) { return columns; }
const newColumns = columns.slice(0);
newColumns[projectIndex] = 'Repo';
return newColumns;
},
};
})(window);
</script>