opendev/gerrit
Code Issues Proposed changes
Files
cd6572d43516b8735e420332b803a319fe57a66c
gerrit/Documentation
History
Bruce Zu cd6572d435 Prevent duplicate commits in same project when uploading to refs/changes/n 
Under certain circumstances, when pushing to 'refs/changes/n', the same
commit can be pushed onto multiple changes even if they are on the same
branch.

As a result of this, if the commit sha1 is used as change identifier
in the 'review' ssh command, it will fail with the error:

  'fatal: <SHA1> matches multiple patch sets.'

This commit performs the same check as when pushing to 'refs/for/branch'
to prevent this, and will show "commit already exists (in the project)"
error message to reject uploading a commit to an existing change via
`refs/changes/n` if the commit was already successfully pushed to a change
in project scope.

Bug: issue 2374
Change-Id: I1c000b2cc3e155617cdc9c295a46ce2107ec47ca
2014-03-11 08:26:36 +00:00
..
images
First Cut of Gerrit Walkthrough Introduction documentation.
2011-12-28 12:33:39 -07:00
man
Add SSH command to set group members
2013-06-14 20:30:32 +02:00
access-control.txt
ReceiveCommits: Fix PUSH permission check for draft changes
2014-01-27 20:53:24 +01:00
asciidoc.defs
Make the documentation embedding work.
2013-10-18 01:28:23 +00:00
BUCK
Index documentation using lucene.
2013-09-27 09:31:32 -07:00
cmd-ban-commit.txt
Add SSH command to ban commits
2012-03-30 16:12:42 +02:00
cmd-cherry-pick.txt
Tell curl to follow redirects for commit-msg hook
2013-05-10 16:17:10 +01:00
cmd-create-account.txt
Improve documentation of the create-account command
2013-08-24 12:10:25 +09:00
cmd-create-group.txt
Fix and complete synopsis of commands in documentation
2012-07-16 13:53:22 +02:00
cmd-create-project.txt
Add REBASE_IF_NECESSARY in documentation of add-project and set-project
2013-09-16 22:26:48 +09:00
cmd-flush-caches.txt
Access control documentation: Flush caches capability
2012-03-21 17:43:29 +01:00
cmd-gc.txt
Add SSH command to run Git garbage collection
2013-03-20 21:36:09 -07:00
cmd-gsql.txt
Add gsql format that returns result set as single Json object
2013-08-17 00:46:36 +02:00
cmd-hook-commit-msg.txt
Document that the commit-msg hook honors gerrit.createChangeId
2013-08-08 15:11:31 +09:00
cmd-index.txt
Remove deprecated approve SSH alias
2013-11-27 21:22:06 +01:00
cmd-kill.txt
Access control documentation: Kill and priority capabilities
2012-03-21 17:43:29 +01:00
cmd-ls-groups.txt
Support to check via REST if a group is owned by the calling user
2013-02-08 14:48:38 +01:00
cmd-ls-members.txt
Added a ls-members command to the ssh daemon.
2013-05-08 07:51:59 -07:00
cmd-ls-projects.txt
ls-projects: Add option to list projects on which a certain group is used
2012-08-31 15:53:04 +02:00
cmd-ls-user-refs.txt
Fix ls-user-refs command name in documentation
2013-05-01 12:19:28 +02:00
cmd-plugin-enable.txt
Add ssh command to enable plugins
2012-07-26 16:24:47 -05:00
cmd-plugin-install.txt
Allow plugins to provide their own name
2013-09-26 10:56:18 +09:00
cmd-plugin-ls.txt
Document SSH commands gerrit plugin {ls|install|remove|reload}
2012-07-17 16:07:02 +02:00
cmd-plugin-reload.txt
Document that on reload of a plugin a new plugin configuration gets active
2012-07-18 12:48:36 +02:00
cmd-plugin-remove.txt
Document SSH commands gerrit plugin {ls|install|remove|reload}
2012-07-17 16:07:02 +02:00
cmd-query.txt
Add clarifications in the documentation of the query command
2013-05-02 14:29:41 +00:00
cmd-receive-pack.txt
Add options to refs/for/ magic branch syntax
2013-02-27 16:07:30 -08:00
cmd-rename-group.txt
Add new SSH command to rename groups
2011-10-27 00:28:11 +02:00
cmd-review.txt
Update documentation of the review command
2013-11-28 12:25:22 +09:00
cmd-set-account.txt
Update HTTP password from SSH commands.
2012-09-13 09:15:02 +02:00
cmd-set-members.txt
Add SSH command to set group members
2013-06-14 20:30:32 +02:00
cmd-set-project-parent.txt
Support to reparent all children of a parent project
2011-11-16 09:34:26 +01:00
cmd-set-project.txt
Add REBASE_IF_NECESSARY in documentation of add-project and set-project
2013-09-16 22:26:48 +09:00
cmd-set-reviewers.txt
Fix and complete synopsis of commands in documentation
2012-07-16 13:53:22 +02:00
cmd-show-caches.txt
Add --wide option to show-connections
2013-06-11 01:36:31 -05:00
cmd-show-connections.txt
Add --wide option to show-connections
2013-06-11 01:36:31 -05:00
cmd-show-queue.txt
Fix spelling mistakes in the documentation
2013-06-24 10:16:28 +09:00
cmd-stream-events.txt
Document how plugins can listen to stream-events
2013-10-31 13:49:25 +01:00
cmd-suexec.txt
suexec: Honor Run As capability like HTTP REST API
2013-06-11 13:56:13 -07:00
cmd-test-submit-rule.txt
Add REST APIs to test submit_rule and submit_filter
2013-03-04 11:13:36 -08:00
cmd-test-submit-type.txt
Add documentation for the SSH 'test-submit type' command
2013-03-26 10:50:19 +01:00
cmd-version.txt
Fix documentation
2013-08-29 15:14:50 -07:00
config-auto-site-initialization.txt
Optionally, initialize site from WebAppInitializer.
2013-09-18 12:52:17 -07:00
config-cla.txt
Minor documentation tidy-up
2013-01-07 17:30:55 +09:00
config-contact.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
config-gerrit.txt
Support committing Lucene writes within a fixed interval
2014-02-17 14:29:21 -05:00
config-gitweb.txt
Remove non-ASCII character from documentation
2013-05-10 10:23:31 -07:00
config-hooks.txt
Add --project and --branch parameters on the topic-changed hook
2013-11-07 15:21:41 +09:00
config-labels.txt
Support copying of approvals if new patch set has no code changes
2013-09-27 20:15:08 +02:00
config-login-register.txt
Fixed several spelling mistakes
2013-11-28 12:25:16 +09:00
config-mail.txt
Update documentation of new change and patch set mail notifications
2013-07-11 22:32:36 +09:00
config-project-config.txt
Config file documentation: refs/meta/config and capabilities
2013-10-16 16:52:12 +02:00
config-reverseproxy.txt
Documentation: Reverse Proxy Configuration
2013-06-05 08:55:10 +02:00
config-sso.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
config-themes.txt
Allow projects to specify themes
2013-04-10 10:47:03 -07:00
config-validation.txt
Add merge validation interface
2013-08-08 11:32:21 +09:00
config.defs
Disable "Last updated" footer in asciidoctor HTML
2013-10-08 17:45:39 +00:00
database-setup.txt
Fix documentation
2013-08-29 15:14:50 -07:00
dev-buck.txt
Improve documentation of buck settings override
2013-10-17 00:14:47 +09:00
dev-contributing.txt
Document how to set commit-msg hook for plugin submodules
2013-07-10 22:10:20 +09:00
dev-design.txt
Fixed several spelling mistakes
2013-11-28 12:25:16 +09:00
dev-eclipse.txt
Delete Maven based build
2013-05-21 20:28:56 -07:00
dev-plugins.txt
Add link to validation listeners in the plugin documentation
2014-01-23 09:29:16 +01:00
dev-readme.txt
Replace "\--" with "--" in documentation.
2013-12-10 16:40:50 +09:00
dev-release-deploy-config.txt
Update cloud storage console URL in artifact deployment instructions
2013-12-04 17:21:41 +09:00
dev-release-subproject.txt
Update URLs for Google Cloud Storage
2013-06-21 11:01:45 -07:00
dev-release.txt
Fix documentation
2013-08-29 15:14:50 -07:00
dev-rest-api.txt
Document how to send file content without conversion using curl
2013-05-30 17:03:31 +02:00
doc.css
Add border for tables in documentation
2014-02-19 10:29:34 +01:00
error-branch-not-found.txt
Adapt documentation to having 'Projects' as top level menu
2012-12-12 13:09:05 +01:00
error-change-closed.txt
Add documentation of "change closed" error when using ssh review
2012-06-27 10:10:23 +02:00
error-change-does-not-belong-to-project.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-change-not-found.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-change-upload-blocked.txt
Added explanation for "One or more refs/for/ ..." error
2011-02-03 08:53:46 +01:00
error-commit-already-exists.txt
Prevent duplicate commits in same project when uploading to refs/changes/n
2014-03-11 08:26:36 +00:00
error-contains-banned-commit.txt
Added explanation for "contains banned commit" error
2011-04-08 11:00:40 +02:00
error-has-duplicates.txt
Fix documentation
2013-08-29 15:14:50 -07:00
error-invalid-author.txt
Correct documentation of "invalid author/committer" errors
2012-06-26 09:24:47 +02:00
error-invalid-changeid-line.txt
Clarify error messages related to commit message footer content
2012-11-13 12:18:16 +09:00
error-invalid-committer.txt
Correct documentation of "invalid author/committer" errors
2012-06-26 09:24:47 +02:00
error-messages.txt
Fix error documentation for NoSuchProjectException
2013-02-19 08:39:18 +01:00
error-missing-changeid.txt
Add another case to the documentation of the missing Change-Id error
2013-07-05 09:21:35 +02:00
error-multiple-changeid-lines.txt
Clarify error messages related to commit message footer content
2012-11-13 12:18:16 +09:00
error-no-changes-made.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-no-common-ancestry.txt
Added explanation for "no common ancestry" error
2011-01-25 15:33:40 +01:00
error-no-new-changes.txt
Prevent duplicate commits in same project when uploading to refs/changes/n
2014-03-11 08:26:36 +00:00
error-non-fast-forward.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-not-a-gerrit-administrator.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-not-allowed-to-upload-merges.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-not-permitted-to-create.txt
Added explanation for "Not permitted to create" error
2011-02-04 10:22:50 +01:00
error-not-signed-off-by.txt
Clarify error messages related to commit message footer content
2012-11-13 12:18:16 +09:00
error-not-valid-ref.txt
Added explanation for "not valid ref" error
2011-01-12 07:12:36 -08:00
error-permission-denied.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-prohibited-by-gerrit.txt
Add another case to the prohibited by Gerrit error documentation
2014-02-20 14:49:17 +01:00
error-project-not-found.txt
Fix error documentation for NoSuchProjectException
2013-02-19 08:39:18 +01:00
error-push-fails-due-to-commit-message.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-squash-commits-first.txt
Documentation: Various corrections
2012-06-12 14:54:54 +02:00
error-upload-denied.txt
Access control documentation: Read and Submit
2012-01-23 16:46:57 +01:00
gen_licenses.py
Rename licenses.py to gen_licenses.py
2013-05-18 14:08:02 -07:00
i18n-readme.txt
Document new project-specific label configuration
2013-03-14 14:22:27 -07:00
index.txt
Documentation: Update download link
2014-01-17 11:49:51 +09:00
install-j2ee.txt
Optionally, initialize site from WebAppInitializer.
2013-09-18 12:52:17 -07:00
install-quick.txt
Separate the initial user setup instructions to a shared file
2012-11-28 16:54:10 +09:00
install.txt
Add missing steps for daemon auto start/stop in install documentation
2013-10-24 18:55:29 +09:00
intro-change-screen.txt
Documentation: Improve the description of the change screen preference
2014-02-12 17:11:23 +09:00
intro-quick.txt
Document new project-specific label configuration
2013-03-14 14:22:27 -07:00
js-api.txt
Add support for UiActions on Project Info Screen
2013-09-27 14:13:17 +09:00
json.txt
Bring draft status to PatchSetAttribute
2013-07-05 23:13:08 +02:00
pgm-daemon.txt
Replace "\--" with "--" in documentation.
2013-12-10 16:40:50 +09:00
pgm-gsql.txt
Replace "\--" with "--" in documentation.
2013-12-10 16:40:50 +09:00
pgm-index.txt
Add initial documentation for the 'reindex' program
2013-08-23 12:32:07 +09:00
pgm-init.txt
Fix broken formatting in pgm-init.txt
2013-12-10 18:41:38 +09:00
pgm-LocalUsernamesToLowerCase.txt
Replace "\--" with "--" in documentation.
2013-12-10 16:40:50 +09:00
pgm-prolog-shell.txt
Fix spelling mistakes in the documentation
2013-06-24 10:16:28 +09:00
pgm-reindex.txt
Add documentation section for secondary index configuration
2013-08-23 17:06:38 +09:00
pgm-rulec.txt
Fix spelling mistakes in Gerrit documentation
2011-10-27 02:24:06 +02:00
pgm-ScanTrackingIds.txt
Extract tr: values from commit instead of database
2013-10-08 11:18:31 -07:00
project-setup.txt
Improve explanation of path conflicts in project config doc
2013-05-14 17:45:32 +09:00
prolog-change-facts.txt
Expose basic commit statistics for the prolog rule engine.
2012-10-23 10:32:25 -04:00
prolog-cookbook.txt
Merge branch 'stable-2.7'
2013-09-18 13:13:29 -07:00
replace_macros.py
Upgrade asciidoctor to 0.1.4
2013-10-08 10:27:08 -07:00
rest-api-access.txt
Include in ProjectAccessInfo whether the calling user is project owner
2013-07-12 13:21:15 +02:00
rest-api-accounts.txt
Fix minor typo in REST API accounts documentation
2014-02-21 12:30:53 +09:00
rest-api-changes.txt
Another attempt to fix submit rule evaluation for non blocking labels
2014-03-06 07:19:15 +00:00
rest-api-config.txt
Support 'id' attribute for menu items contributed by plugins
2013-11-06 09:24:47 +01:00
rest-api-groups.txt
Fixed invalid JSON in REST API examples
2013-08-06 16:25:24 -04:00
rest-api-plugins.txt
Revert unwanted commits accidentally included from master
2013-10-24 11:26:01 +09:00
rest-api-projects.txt
Add support for UiActions on Project Info Screen
2013-09-27 14:13:17 +09:00
rest-api.txt
Document REST endpoint to install plugins
2013-08-30 16:03:25 +02:00
user-changeid.txt
Tell curl to follow redirects for commit-msg hook
2013-05-10 16:17:10 +01:00
user-dashboards.txt
Document: Improve the dashboards document
2013-08-09 13:14:11 +08:00
user-notify.txt
Add clarification of email notifications in documentation
2013-07-08 16:51:55 +09:00
user-search.txt
Fix examples for Code-Review queries in search documentation
2014-01-13 13:34:25 +00:00
user-signedoffby.txt
Fixed several spelling mistakes
2013-11-28 12:25:16 +09:00
user-submodules.txt
Improve submodule subscription documentation
2013-05-08 00:17:16 +02:00
user-upload.txt
Allow opening new changes on existing commits
2013-04-22 11:57:40 -07:00