The changeCache is null when in the context of BatchProgramModule.
The only consumer of changeCache, VisibleRefFilter, is prepared to
handle a null value, so in all code paths it is okay for it to be
null.
This makes reindex work again. Regression introduced in
a758640bc33c20cead19b86a32db075c776c4140 (VisibleRefFilter: Avoid
touching the database for drafts, 2016-06-03):
$ java -jar buck-out/gen/gerrit/gerrit.war reindex -d ../gerrit-testsite
[...]
Reindexing changes: projects: 66% (2/3)[2016-06-06 16:18:36,781] [Index-Batch-3] WARN com.google.gerrit.server.index.change.AllChangesIndexer : Failed to index change 18
com.google.inject.ProvisionException: Unable to provision, see the following errors:
1) null returned by binding at com.google.gerrit.pgm.util.BatchProgramModule.configure(BatchProgramModule.java:126)
but parameter 8 of com.google.gerrit.server.project.ProjectControl.<init>() is not @Nullable
while locating com.google.gerrit.server.git.SearchingChangeCacheImpl
for parameter 8 at com.google.gerrit.server.project.ProjectControl.<init>(ProjectControl.java:177)
while locating com.google.gerrit.server.project.ProjectControl annotated with @com.google.inject.internal.UniqueAnnotations$Internal(value=4)
Reported-by: Viktar Donich <viktard@google.com>
Change-Id: Ia0ca0e0e153c9f357e5ebc6edf4b1962a2490f2d
b273cfd04d