Files
gerrit/gerrit-server
Edwin Kempin 8b1fe0b0d3 ChangeJson: Fix NPE when Non-Author-Code-Review is configured
When Non-Author-Code-Review was configured computing the labels for
closed changes failed with the following NullPointerException:

  Caused by: java.lang.NullPointerException
    at com.google.gerrit.server.change.ChangeJson.setLabelValues(ChangeJson.java:888)
    at com.google.gerrit.server.change.ChangeJson.lambda$0(ChangeJson.java:826)
    at java.util.TreeMap$EntrySpliterator.forEachRemaining(TreeMap.java:2969)
    at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
    at com.google.gerrit.server.change.ChangeJson.labelsForClosedChange(ChangeJson.java:826)
    at com.google.gerrit.server.change.ChangeJson.labelsFor(ChangeJson.java:604)
    at com.google.gerrit.server.change.ChangeJson.toChangeInfo(ChangeJson.java:503)
    at com.google.gerrit.server.change.ChangeJson.format(ChangeJson.java:298)
    ... 44 more

Fix this by filtering out labels that only exist in Prolog when
setting detailled labels. For open changes they are already filtered
out.

This issue was introduced by change Iba501e.

Change-Id: Icc7c5ba1a4242e8d10f19727be3d895bb5139311
Signed-off-by: Edwin Kempin <ekempin@google.com>
2016-11-24 17:14:33 +01:00
..
2016-11-07 11:18:50 +01:00
2016-11-08 12:53:23 +01:00