d03143571d
Gerrit can index a boolean field called 'mergeable' that determines if a change can be merged into the target ref. This bit can change whenever the target ref advances. Gerrit therefore has logic to reindex all open changes when the target ref advances. Depending on the number of open changes, the frequency of updates of the target ref and the size of the repo, this can be a very expensive operation. For large installations, 'reindexAfterRefUpdate' was added as a setting back in 2015 (I88ae7f4ad) to turn off automatic reindexing. This setting however, leads to inconsistent behavior: Gerrit stops updating documents when the target ref advances, so the 'mergeable' bit in the indexed document can be stale. For large repos, it is most likely stale. Users can still query for 'is:mergeable' though and Gerrit happily serves that stale bit in any query response. It is worth noting, that all of this does not affect the UI as that sends a separate, asynchronous request to compute mergeablitly when needed and does not rely on the index. This commit cleans this behavior up by replacing reindexAfterRefUpdate with indexMergeable. After this commit, there are two modes of operation: 1) Gerrit indexes 'mergable' and keeps it up to date when the target ref advances. Gerrit allows queries for 'is:mergeable'. 2) Gerrit does not index 'mergeable' at all. Gerrit does not allow queries for 'is:mergeable'. This way, users always get a consistent and correct result. Change-Id: I053af1b99616920db7f0dda8f8ec770e8683df5c
64 lines
2.2 KiB
Java
64 lines
2.2 KiB
Java
// Copyright (C) 2018 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.elasticsearch.bulk;
|
|
|
|
import static java.util.stream.Collectors.toList;
|
|
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.google.common.collect.Iterables;
|
|
import com.google.common.collect.Streams;
|
|
import com.google.gerrit.elasticsearch.builders.XContentBuilder;
|
|
import com.google.gerrit.index.Schema;
|
|
import com.google.gerrit.index.Schema.Values;
|
|
import java.io.IOException;
|
|
|
|
public class UpdateRequest<V> extends BulkRequest {
|
|
|
|
private final Schema<V> schema;
|
|
private final V v;
|
|
private final ImmutableSet<String> skipFields;
|
|
|
|
public UpdateRequest(Schema<V> schema, V v, ImmutableSet<String> skipFields) {
|
|
this.schema = schema;
|
|
this.v = v;
|
|
this.skipFields = skipFields;
|
|
}
|
|
|
|
@Override
|
|
protected String getRequest() {
|
|
try (XContentBuilder closeable = new XContentBuilder()) {
|
|
XContentBuilder builder = closeable.startObject();
|
|
for (Values<V> values : schema.buildFields(v, skipFields)) {
|
|
String name = values.getField().getName();
|
|
if (values.getField().isRepeatable()) {
|
|
builder.field(name, Streams.stream(values.getValues()).collect(toList()));
|
|
} else {
|
|
Object element = Iterables.getOnlyElement(values.getValues(), "");
|
|
if (shouldAddElement(element)) {
|
|
builder.field(name, element);
|
|
}
|
|
}
|
|
}
|
|
return builder.endObject().string() + System.lineSeparator();
|
|
} catch (IOException e) {
|
|
return e.toString();
|
|
}
|
|
}
|
|
|
|
private boolean shouldAddElement(Object element) {
|
|
return !(element instanceof String) || !((String) element).isEmpty();
|
|
}
|
|
}
|