Files
gerrit/java
Luke Alonso d032872af8 Fix 'is:submittable' query on multiple submit records
When a project has multiple submit rules, which produce
multiple submit records, the 'is:submittable' query stops
working as the documentation indicates it should. Rather
than returning changes that are ready to be submitted,
it returns any change where at least one submit record
is OK, despite the overall change not being submittable.

For example, with the code-owners plugin, which uses
a java-based submit rule, 'is:submittable' will return
changes that are passing owners checks, but might
have CodeReview:-2 or Verified:-1.

For projects with a single submit rule, the behavior
is exactly the same as before, since we simply check
that *any* of the submit records is OK, exactly as before,
AND that *none* of them are NOT_READY or RULE_ERROR.

Bug: Issue 13884
Change-Id: I4878ce13c6673852916d6891253d5e62b46f3db5
2020-12-31 07:32:06 +00:00
..