292d013f32
In the JSON of emitted by the repo list endpoint, the project IDs are URL-encoded using java.net.URLEncoder.encode. While the Java function encodes spaces as plus-signs, the JavaScript decodeURLComponent does not. As a result, when editing the "inherits from" field of a project's access settings where the parent project's ID includes spaces, the payload would use an improperly decoded parent value, and this would be rejected by the API for failing to identify the parent. Add a new decoding method to the URL encoding behavior that better matches the style of encoding used by java.net.URLEncoder. Because the behavior had no test coverage before, it's moved to a new location and a suite of tests are added. Add tests for the access screen properly encoding and decoding parent IDs. Change-Id: Icb1d28d8f1f88c3c7373aa1c8953238a61c32ace
128 lines
4.3 KiB
HTML
128 lines
4.3 KiB
HTML
<!--
|
|
@license
|
|
Copyright (C) 2017 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<link rel="import" href="../../../bower_components/iron-autogrow-textarea/iron-autogrow-textarea.html">
|
|
<link rel="import" href="../../../bower_components/iron-input/iron-input.html">
|
|
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
|
<link rel="import" href="../../../behaviors/base-url-behavior/base-url-behavior.html">
|
|
<link rel="import" href="../../../behaviors/gr-url-encoding-behavior/gr-url-encoding-behavior.html">
|
|
<link rel="import" href="../../../styles/gr-form-styles.html">
|
|
<link rel="import" href="../../../styles/shared-styles.html">
|
|
<link rel="import" href="../../core/gr-navigation/gr-navigation.html">
|
|
<link rel="import" href="../../shared/gr-autocomplete/gr-autocomplete.html">
|
|
<link rel="import" href="../../shared/gr-button/gr-button.html">
|
|
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
|
|
<link rel="import" href="../../shared/gr-select/gr-select.html">
|
|
|
|
<dom-module id="gr-create-change-dialog">
|
|
<template>
|
|
<style include="shared-styles"></style>
|
|
<style include="gr-form-styles">
|
|
:host {
|
|
display: inline-block;
|
|
}
|
|
input:not([type="checkbox"]),
|
|
gr-autocomplete,
|
|
iron-autogrow-textarea {
|
|
width: 100%;
|
|
}
|
|
.value {
|
|
width: 32em;
|
|
}
|
|
section {
|
|
align-items: center;
|
|
display: flex;
|
|
}
|
|
#description {
|
|
align-items: initial;
|
|
}
|
|
gr-autocomplete {
|
|
--gr-autocomplete: {
|
|
padding: 0 .15em;
|
|
}
|
|
}
|
|
.hideBranch {
|
|
display: none;
|
|
}
|
|
</style>
|
|
<div class="gr-form-styles">
|
|
<div id="form">
|
|
<section class$="[[_computeBranchClass(baseChange)]]">
|
|
<span class="title">Select branch for new change</span>
|
|
<span class="value">
|
|
<gr-autocomplete
|
|
id="branchInput"
|
|
text="{{branch}}"
|
|
query="[[_query]]"
|
|
placeholder="Destination branch">
|
|
</gr-autocomplete>
|
|
</span>
|
|
</section>
|
|
<section class$="[[_computeBranchClass(baseChange)]]">
|
|
<span class="title">Provide base commit sha1 for change</span>
|
|
<span class="value">
|
|
<input
|
|
is="iron-input"
|
|
id="baseCommitInput"
|
|
maxlength="40"
|
|
placeholder="(optional)"
|
|
bind-value="{{baseCommit}}">
|
|
</span>
|
|
</section>
|
|
<section>
|
|
<span class="title">Enter topic for new change</span>
|
|
<span class="value">
|
|
<input
|
|
is="iron-input"
|
|
id="tagNameInput"
|
|
maxlength="1024"
|
|
placeholder="(optional)"
|
|
bind-value="{{topic}}">
|
|
</span>
|
|
</section>
|
|
<section id="description">
|
|
<span class="title">Description</span>
|
|
<span class="value">
|
|
<iron-autogrow-textarea
|
|
id="messageInput"
|
|
class="message"
|
|
autocomplete="on"
|
|
rows="4"
|
|
max-rows="15"
|
|
bind-value="{{subject}}"
|
|
placeholder="Insert the description of the change.">
|
|
</iron-autogrow-textarea>
|
|
</span>
|
|
</section>
|
|
<section>
|
|
<label
|
|
class="title"
|
|
for="privateChangeCheckBox">Private change</label>
|
|
<span class="value">
|
|
<input
|
|
type="checkbox"
|
|
id="privateChangeCheckBox"
|
|
checked$="[[_formatBooleanString(privateByDefault)]]">
|
|
</span>
|
|
</section>
|
|
</div>
|
|
</div>
|
|
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
|
|
</template>
|
|
<script src="gr-create-change-dialog.js"></script>
|
|
</dom-module>
|