947b5e53ac
Split the current gerrit-acceptance-tests in two parts:
* framework + some needed deps, that is exposed as additional plugin
artifact
* rest of the gerrit-acceptance-test project
To implement the split and not to pull in too many dependencies, some
refactoring was needed. Particularly, gerrit-server:testutil depends
on gerrit-server:server, that depends on almost everything. Similar
problem was with gerrit-pgm:pgm, that is needed for AbstractDaemonTest
to work. Split the rules in gerrit-pgm to break transitive dependency
chain. We shouldn't ship artifacts twice, in plugin-api and in
acceptance-framework.
This change also partially reverts Ie9e63de622, where
//gerrit-acceptance-tests:lib with all its transitive dependencies was
included in plugin-api artifact.
Expose gerrit-acceptance-framework as new plugin artifact. This allows
us to support unit tests in plugins in three different build modes:
* Buck in tree build mode
* Buck standalone build mode
* Maven build
To install gerrit-acceptance-framework locally, the following command
is used:
buck build api_install
To deploy gerrit-acceptance-framework to Maven Central, the following
command is used:
buck build api_deploy
To support unit tests in tree build mode, the following Buck variable
is exposed: GERRIT_TESTS and can be used, e.g.:
java_test(
name = 'cookbook_tests',
srcs = glob(['src/test/java/**/*IT.java']),
labels = ['cookbook-plugin'],
source_under_test = [':cookbook-plugin__plugin'],
deps = GERRIT_PLUGIN_API + GERRIT_TESTS + [
':cookbook-plugin__plugin',
],
)
To support unit tests in standalone build mode, acceptance-framework
maven jar is defined in lib/gerrit/BUCK file:
maven_jar(
name = 'acceptance-framework',
id = 'com.google.gerrit:gerrit-acceptance-framework:' + VER,
license = 'Apache2.0',
attach_source = False,
repository = REPO,
)
bucklets/gerrit_plugin.bucklet is extended with the same variable
that points to the new maven_jar artifact, so that the same Buck
java_test() rule can be used in both modes.
Test plan:
1. run tests in gerrit tree
2. apply corresponding change to cookbook-plugin and run tests in
gerrit tree mode
3. apply corresponding change to bucklets, and run tests for
cookbook-plugin in standalone build mode
Change-Id: I4cadf6616de36ca24712f8b07d282b7a50911105
42 lines
1.1 KiB
Python
42 lines
1.1 KiB
Python
include_defs('//tools/build.defs')
|
|
|
|
gerrit_war(name = 'gerrit')
|
|
gerrit_war(name = 'headless', ui = None)
|
|
gerrit_war(name = 'chrome', ui = 'ui_chrome')
|
|
gerrit_war(name = 'firefox', ui = 'ui_firefox')
|
|
gerrit_war(name = 'safari', ui = 'ui_safari')
|
|
gerrit_war(name = 'withdocs', docs = True)
|
|
gerrit_war(name = 'release', ui = 'ui_optdbg_r', docs = True, context = ['//plugins:core'], visibility = ['//tools/maven:'])
|
|
|
|
API_DEPS = [
|
|
'//gerrit-acceptance-framework:api',
|
|
'//gerrit-acceptance-framework:src',
|
|
'//gerrit-acceptance-framework:javadoc',
|
|
'//gerrit-extension-api:extension-api',
|
|
'//gerrit-extension-api:extension-api-src',
|
|
'//gerrit-extension-api:extension-api-javadoc',
|
|
'//gerrit-plugin-api:plugin-api',
|
|
'//gerrit-plugin-api:plugin-api-src',
|
|
'//gerrit-plugin-api:plugin-api-javadoc',
|
|
'//gerrit-plugin-gwtui:gwtui-api',
|
|
'//gerrit-plugin-gwtui:gwtui-api-src',
|
|
'//gerrit-plugin-gwtui:gwtui-api-javadoc',
|
|
]
|
|
|
|
genrule(
|
|
name = 'api',
|
|
cmd = 'echo done >$OUT',
|
|
deps = API_DEPS,
|
|
out = '__fake.api__',
|
|
)
|
|
|
|
genrule(
|
|
name = 'all',
|
|
cmd = 'echo done >$OUT',
|
|
deps = [
|
|
':api',
|
|
':release',
|
|
],
|
|
out = '__fake.all__',
|
|
)
|