Files
gerrit/polygerrit-ui/app/elements/change/gr-messages-list/gr-messages-list.html
Kasper Nilsson 5da159ee8d Fix bug in comment control hiding
The logic for showing/hiding the 'Show x more' control for messages made
some invalid assumptions, specifically regarding the content of the
_visibleMessages array.

This change adds a new function, _getHumanMessages, that is utilized in
the affected functions to prune the array down to its proper contents to
make the calculations about whether the control should be hidden and
what its labels should say much easier.

Bug: Issue 5749
Change-Id: I465fbff9c8deab0e2357461aa9bdf37e0e6a8299
2017-03-09 17:52:50 -08:00

104 lines
3.5 KiB
HTML

<!--
Copyright (C) 2015 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<link rel="import" href="../../../bower_components/polymer/polymer.html">
<link rel="import" href="../../core/gr-reporting/gr-reporting.html">
<link rel="import" href="../../shared/gr-button/gr-button.html">
<link rel="import" href="../gr-message/gr-message.html">
<dom-module id="gr-messages-list">
<template>
<style>
:host,
.messageListControls {
display: block;
}
.header {
display: flex;
justify-content: space-between;
margin-bottom: .35em;
}
.header,
#messageControlsContainer,
gr-message {
padding: 0 var(--default-horizontal-margin);
}
.highlighted {
animation: 3s fadeOut;
}
@keyframes fadeOut {
0% { background-color: #fff9c4; }
100% { background-color: #fff; }
}
#messageControlsContainer {
align-items: center;
background-color: #fef;
display: flex;
justify-content: center;
}
#messageControlsContainer gr-button {
padding: 0.4em;
}
</style>
<div class="header">
<h3>Messages</h3>
<div class="messageListControls">
<gr-button id="collapse-messages" link
on-tap="_handleExpandCollapseTap">
[[_computeExpandCollapseMessage(_expanded)]]
</gr-button>
<span
id="automatedMessageToggleContainer"
hidden$="[[!_hasAutomatedMessages(messages)]]">
/
<gr-button id="automatedMessageToggle" link
on-tap="_handleAutomatedMessageToggleTap">
[[_computeAutomatedToggleText(_hideAutomated)]]
</gr-button>
</span>
</div>
</div>
<span
id="messageControlsContainer"
hidden$="[[_computeShowHideTextHidden(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]">
<gr-button id="oldMessagesBtn" link on-tap="_handleShowAllTap">
[[_computeNumMessagesText(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]
</gr-button>
/
<gr-button id="incrementMessagesBtn" link
on-tap="_handleIncrementShownMessages">
[[_computeIncrementText(_visibleMessages, _processedMessages, _hideAutomated, _visibleMessages.length)]]
</gr-button>
</span>
<template
is="dom-repeat"
items="[[_visibleMessages]]"
as="message">
<gr-message
change-num="[[changeNum]]"
message="[[message]]"
comments="[[_computeCommentsForMessage(comments, message)]]"
hide-automated="[[_hideAutomated]]"
project-config="[[projectConfig]]"
show-reply-button="[[showReplyButtons]]"
on-scroll-to="_handleScrollTo"
data-message-id$="[[message.id]]"></gr-message>
</template>
<gr-reporting id="reporting" category="message-list"></gr-reporting>
</template>
<script src="gr-messages-list.js"></script>
</dom-module>