5827312720
Because modifying the name and status field in account-info requires two separate API calls, a race was occurring server side that caused the DB to reject the modification of the status field most of the time. Before, the requests to set status and name were made every time. Now, the requests are made synchronously, and are only made if the corresponding property of the account object was actually modified. Bug: Issue 5721 Change-Id: I38d2927cbd0998a0debc414ed09ca1f74e8354ff
137 lines
3.4 KiB
JavaScript
137 lines
3.4 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-account-info',
|
|
|
|
/**
|
|
* Fired when account details are changed.
|
|
*
|
|
* @event account-detail-update
|
|
*/
|
|
|
|
properties: {
|
|
mutable: {
|
|
type: Boolean,
|
|
notify: true,
|
|
computed: '_computeMutable(_serverConfig)',
|
|
},
|
|
hasUnsavedChanges: {
|
|
type: Boolean,
|
|
notify: true,
|
|
computed: '_computeHasUnsavedChanges(_hasNameChange, _hasStatusChange)',
|
|
},
|
|
|
|
_hasNameChange: {
|
|
type: Boolean,
|
|
value: false,
|
|
},
|
|
_hasStatusChange: {
|
|
type: Boolean,
|
|
value: false,
|
|
},
|
|
_loading: {
|
|
type: Boolean,
|
|
value: false,
|
|
},
|
|
_saving: {
|
|
type: Boolean,
|
|
value: false,
|
|
},
|
|
_account: Object,
|
|
_serverConfig: Object,
|
|
},
|
|
|
|
observers: [
|
|
'_nameChanged(_account.name)',
|
|
'_statusChanged(_account.status)',
|
|
],
|
|
|
|
loadData: function() {
|
|
var promises = [];
|
|
|
|
this._loading = true;
|
|
|
|
promises.push(this.$.restAPI.getConfig().then(function(config) {
|
|
this._serverConfig = config;
|
|
}.bind(this)));
|
|
|
|
promises.push(this.$.restAPI.getAccount().then(function(account) {
|
|
this._account = account;
|
|
}.bind(this)));
|
|
|
|
return Promise.all(promises).then(function() {
|
|
this._loading = false;
|
|
}.bind(this));
|
|
},
|
|
|
|
save: function() {
|
|
if (!this.mutable || !this.hasUnsavedChanges) {
|
|
return Promise.resolve();
|
|
}
|
|
|
|
this._saving = true;
|
|
// Set only the fields that have changed.
|
|
// Must be done in sequence to avoid race conditions (@see Issue 5721)
|
|
return this._maybeSetName()
|
|
.then(this._maybeSetStatus.bind(this))
|
|
.then(function() {
|
|
this._hasNameChange = false;
|
|
this._hasStatusChange = false;
|
|
this._saving = false;
|
|
this.fire('account-detail-update');
|
|
}.bind(this));
|
|
},
|
|
|
|
_maybeSetName: function() {
|
|
return this._hasNameChange ?
|
|
this.$.restAPI.setAccountName(this._account.name) :
|
|
Promise.resolve();
|
|
},
|
|
|
|
_maybeSetStatus: function() {
|
|
return this._hasStatusChange ?
|
|
this.$.restAPI.setAccountStatus(this._account.status) :
|
|
Promise.resolve();
|
|
},
|
|
|
|
_computeHasUnsavedChanges: function(name, status) {
|
|
return name || status;
|
|
},
|
|
|
|
_computeMutable: function(config) {
|
|
return config.auth.editable_account_fields.indexOf('FULL_NAME') !== -1;
|
|
},
|
|
|
|
_statusChanged: function() {
|
|
if (this._loading) { return; }
|
|
this._hasStatusChange = true;
|
|
},
|
|
|
|
_nameChanged: function() {
|
|
if (this._loading) { return; }
|
|
this._hasNameChange = true;
|
|
},
|
|
|
|
_handleKeydown: function(e) {
|
|
if (e.keyCode === 13) { // Enter
|
|
e.stopPropagation();
|
|
this.save();
|
|
}
|
|
},
|
|
});
|
|
})();
|