Files
gerrit/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-plugin-rest-api_test.js
Ben Rohlfs 3a6ff7ec1f Introduce a proper mock for the RestApiService
Simplify all stubbing of the REST API in tests by adding a canonical
`stubRestApi` method.

Make sure to never use the <gr-rest-api-interface> element directly
anymore, thus paving the way for converting the element into a service
object and moving into to the services directory.

The reviewer should with looking at all non-test files first.

Change-Id: Ida7c9f0482477a0971fda106f18b8c51e20597c6
2021-01-19 14:48:35 +01:00

135 lines
4.3 KiB
JavaScript

/**
* @license
* Copyright (C) 2017 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import '../../../test/common-test-setup-karma.js';
import './gr-js-api-interface.js';
import {GrPluginRestApi} from './gr-plugin-rest-api.js';
import {_testOnly_initGerritPluginApi} from './gr-gerrit.js';
import {stubRestApi} from '../../../test/test-utils.js';
const pluginApi = _testOnly_initGerritPluginApi();
suite('gr-plugin-rest-api tests', () => {
let instance;
let getResponseObjectStub;
let sendStub;
setup(() => {
stubRestApi('getAccount').returns(Promise.resolve({name: 'Judy Hopps'}));
getResponseObjectStub = stubRestApi('getResponseObject').returns(
Promise.resolve());
sendStub = stubRestApi('send').returns(Promise.resolve({status: 200}));
pluginApi.install(p => {}, '0.1',
'http://test.com/plugins/testplugin/static/test.js');
instance = new GrPluginRestApi();
});
test('fetch', () => {
const payload = {foo: 'foo'};
return instance.fetch('HTTP_METHOD', '/url', payload).then(r => {
assert.isTrue(sendStub.calledWith('HTTP_METHOD', '/url', payload));
assert.equal(r.status, 200);
assert.isFalse(getResponseObjectStub.called);
});
});
test('send', () => {
const payload = {foo: 'foo'};
const response = {bar: 'bar'};
getResponseObjectStub.returns(Promise.resolve(response));
return instance.send('HTTP_METHOD', '/url', payload).then(r => {
assert.isTrue(sendStub.calledWith('HTTP_METHOD', '/url', payload));
assert.strictEqual(r, response);
});
});
test('get', () => {
const response = {foo: 'foo'};
getResponseObjectStub.returns(Promise.resolve(response));
return instance.get('/url').then(r => {
assert.isTrue(sendStub.calledWith('GET', '/url'));
assert.strictEqual(r, response);
});
});
test('post', () => {
const payload = {foo: 'foo'};
const response = {bar: 'bar'};
getResponseObjectStub.returns(Promise.resolve(response));
return instance.post('/url', payload).then(r => {
assert.isTrue(sendStub.calledWith('POST', '/url', payload));
assert.strictEqual(r, response);
});
});
test('put', () => {
const payload = {foo: 'foo'};
const response = {bar: 'bar'};
getResponseObjectStub.returns(Promise.resolve(response));
return instance.put('/url', payload).then(r => {
assert.isTrue(sendStub.calledWith('PUT', '/url', payload));
assert.strictEqual(r, response);
});
});
test('delete works', () => {
const response = {status: 204};
sendStub.returns(Promise.resolve(response));
return instance.delete('/url').then(r => {
assert.isTrue(sendStub.calledWith('DELETE', '/url'));
assert.strictEqual(r, response);
});
});
test('delete fails', () => {
sendStub.returns(Promise.resolve(
{status: 400, text() { return Promise.resolve('text'); }}));
return instance.delete('/url').then(r => {
throw new Error('Should not resolve');
})
.catch(err => {
assert.isTrue(sendStub.calledWith('DELETE', '/url'));
assert.equal('text', err.message);
});
});
test('getLoggedIn', () => {
const stub = stubRestApi('getLoggedIn').returns(Promise.resolve(true));
return instance.getLoggedIn().then(result => {
assert.isTrue(stub.calledOnce);
assert.isTrue(result);
});
});
test('getVersion', () => {
const stub = stubRestApi('getVersion').returns(Promise.resolve('foo bar'));
return instance.getVersion().then(result => {
assert.isTrue(stub.calledOnce);
assert.equal(result, 'foo bar');
});
});
test('getConfig', () => {
const stub = stubRestApi('getConfig').returns(Promise.resolve('foo bar'));
return instance.getConfig().then(result => {
assert.isTrue(stub.calledOnce);
assert.equal(result, 'foo bar');
});
});
});