3a6ff7ec1f
Simplify all stubbing of the REST API in tests by adding a canonical `stubRestApi` method. Make sure to never use the <gr-rest-api-interface> element directly anymore, thus paving the way for converting the element into a service object and moving into to the services directory. The reviewer should with looking at all non-test files first. Change-Id: Ida7c9f0482477a0971fda106f18b8c51e20597c6
121 lines
3.9 KiB
JavaScript
121 lines
3.9 KiB
JavaScript
/**
|
|
* @license
|
|
* Copyright (C) 2018 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
import '../../../test/common-test-setup-karma.js';
|
|
import './gr-repo-branch-picker.js';
|
|
import {stubRestApi} from '../../../test/test-utils.js';
|
|
|
|
const basicFixture = fixtureFromElement('gr-repo-branch-picker');
|
|
|
|
suite('gr-repo-branch-picker tests', () => {
|
|
let element;
|
|
|
|
setup(() => {
|
|
element = basicFixture.instantiate();
|
|
});
|
|
|
|
suite('_getRepoSuggestions', () => {
|
|
let getReposStub;
|
|
setup(() => {
|
|
getReposStub = stubRestApi('getRepos')
|
|
.returns(Promise.resolve([
|
|
{
|
|
id: 'plugins%2Favatars-external',
|
|
name: 'plugins/avatars-external',
|
|
}, {
|
|
id: 'plugins%2Favatars-gravatar',
|
|
name: 'plugins/avatars-gravatar',
|
|
}, {
|
|
id: 'plugins%2Favatars%2Fexternal',
|
|
name: 'plugins/avatars/external',
|
|
}, {
|
|
id: 'plugins%2Favatars%2Fgravatar',
|
|
name: 'plugins/avatars/gravatar',
|
|
},
|
|
]));
|
|
});
|
|
|
|
test('converts to suggestion objects', async () => {
|
|
const input = 'plugins/avatars';
|
|
const suggestions = await element._getRepoSuggestions(input);
|
|
assert.isTrue(getReposStub.calledWith(input));
|
|
const unencodedNames = [
|
|
'plugins/avatars-external',
|
|
'plugins/avatars-gravatar',
|
|
'plugins/avatars/external',
|
|
'plugins/avatars/gravatar',
|
|
];
|
|
assert.deepEqual(suggestions.map(s => s.name), unencodedNames);
|
|
assert.deepEqual(suggestions.map(s => s.value), unencodedNames);
|
|
});
|
|
});
|
|
|
|
suite('_getRepoBranchesSuggestions', () => {
|
|
let getRepoBranchesStub;
|
|
setup(() => {
|
|
getRepoBranchesStub = stubRestApi('getRepoBranches')
|
|
.returns(Promise.resolve([
|
|
{ref: 'refs/heads/stable-2.10'},
|
|
{ref: 'refs/heads/stable-2.11'},
|
|
{ref: 'refs/heads/stable-2.12'},
|
|
{ref: 'refs/heads/stable-2.13'},
|
|
{ref: 'refs/heads/stable-2.14'},
|
|
{ref: 'refs/heads/stable-2.15'},
|
|
]));
|
|
});
|
|
|
|
test('converts to suggestion objects', async () => {
|
|
const repo = 'gerrit';
|
|
const branchInput = 'stable-2.1';
|
|
element.repo = repo;
|
|
const suggestions =
|
|
await element._getRepoBranchesSuggestions(branchInput);
|
|
assert.isTrue(getRepoBranchesStub.calledWith(branchInput, repo, 15));
|
|
const refNames = [
|
|
'stable-2.10',
|
|
'stable-2.11',
|
|
'stable-2.12',
|
|
'stable-2.13',
|
|
'stable-2.14',
|
|
'stable-2.15',
|
|
];
|
|
assert.deepEqual(suggestions.map(s => s.name), refNames);
|
|
assert.deepEqual(suggestions.map(s => s.value), refNames);
|
|
});
|
|
|
|
test('filters out ref prefix', async () => {
|
|
const repo = 'gerrit';
|
|
const branchInput = 'refs/heads/stable-2.1';
|
|
element.repo = repo;
|
|
return element._getRepoBranchesSuggestions(branchInput)
|
|
.then(suggestions => {
|
|
assert.isTrue(getRepoBranchesStub.calledWith(
|
|
'stable-2.1', repo, 15));
|
|
});
|
|
});
|
|
|
|
test('does not query when repo is unset', async () => {
|
|
await element._getRepoBranchesSuggestions('');
|
|
assert.isFalse(getRepoBranchesStub.called);
|
|
element.repo = 'gerrit';
|
|
await element._getRepoBranchesSuggestions('');
|
|
assert.isTrue(getRepoBranchesStub.called);
|
|
});
|
|
});
|
|
});
|
|
|