4f10d777d9
As of M80(chrome version >= 80), chrome removed the native htmlImports support, tho we have the polyfill from webcomponents, the loading of html changed from sync to async which cause a lot test to fail in M80. The fix is introducing a util method `readyToTest` which wait until htmlImports finished before running any tests. Updated some tests to have only one top suite per test so we only need one `readyToTest` and also multiple `readyToTest` actually affect tests' stub functionality. Tested locally with `npm run test` on all passed tests and also with manual failure to make sure the updated tests can still catch any errors if have. Bug: Issue 12294 Change-Id: Ib0c464f8ff9f36a401e6c3b249e6bb6d68ee6e2f
103 lines
3.4 KiB
HTML
103 lines
3.4 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
@license
|
|
Copyright (C) 2019 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-confirm-revert-submission-dialog</title>
|
|
|
|
<script src="/bower_components/webcomponentsjs/custom-elements-es5-adapter.js"></script>
|
|
|
|
<script src="/bower_components/webcomponentsjs/webcomponents-lite.js"></script>
|
|
<script src="/bower_components/web-component-tester/browser.js"></script>
|
|
<script src="../../../test/test-pre-setup.js"></script>
|
|
<link rel="import" href="../../../test/common-test-setup.html"/>
|
|
<link rel="import" href="gr-confirm-revert-submission-dialog.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-confirm-revert-submission-dialog>
|
|
</gr-confirm-revert-submission-dialog>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-confirm-revert-submission-dialog tests', async () => {
|
|
await readyToTest();
|
|
let element;
|
|
let sandbox;
|
|
|
|
setup(() => {
|
|
element = fixture('basic');
|
|
sandbox =sinon.sandbox.create();
|
|
});
|
|
|
|
teardown(() => sandbox.restore());
|
|
|
|
test('no match', () => {
|
|
assert.isNotOk(element.message);
|
|
const alertStub = sandbox.stub();
|
|
element.addEventListener('show-alert', alertStub);
|
|
element._populateRevertSubmissionMessage(
|
|
'not a commitHash in sight'
|
|
);
|
|
assert.isTrue(alertStub.calledOnce);
|
|
});
|
|
|
|
test('single line', () => {
|
|
assert.isNotOk(element.message);
|
|
element._populateRevertSubmissionMessage(
|
|
'one line commit\n\nChange-Id: abcdefg\n',
|
|
'abcd123');
|
|
const expected = 'Revert submission\n\n' +
|
|
'Reason for revert: <INSERT REASONING HERE>\n';
|
|
assert.equal(element.message, expected);
|
|
});
|
|
|
|
test('multi line', () => {
|
|
assert.isNotOk(element.message);
|
|
element._populateRevertSubmissionMessage(
|
|
'many lines\ncommit\n\nmessage\n\nChange-Id: abcdefg\n',
|
|
'abcd123');
|
|
const expected = 'Revert submission\n\n' +
|
|
'Reason for revert: <INSERT REASONING HERE>\n';
|
|
assert.equal(element.message, expected);
|
|
});
|
|
|
|
test('issue above change id', () => {
|
|
assert.isNotOk(element.message);
|
|
element._populateRevertSubmissionMessage(
|
|
'test \nvery\n\ncommit\n\nBug: Issue 42\nChange-Id: abcdefg\n',
|
|
'abcd123');
|
|
const expected = 'Revert submission\n\n' +
|
|
'Reason for revert: <INSERT REASONING HERE>\n';
|
|
assert.equal(element.message, expected);
|
|
});
|
|
|
|
test('revert a revert', () => {
|
|
assert.isNotOk(element.message);
|
|
element._populateRevertSubmissionMessage(
|
|
'Revert "one line commit"\n\nChange-Id: abcdefg\n',
|
|
'abcd123');
|
|
const expected = 'Revert submission\n\n' +
|
|
'Reason for revert: <INSERT REASONING HERE>\n';
|
|
assert.equal(element.message, expected);
|
|
});
|
|
});
|
|
</script>
|