dfe7d71167
The severity of this check was demoted to WARN in Id7911fb6dd8. But then was promoted again to ERROR in I72d6044a4d5. However, the root cause of the compilation breakage is the Error Prone false positive error reporting for ImmutableAnnotationChecker check on Java 11 and later: [1], [2]. Disable the check for now, and consider to re-enable it again, when the breakage is fixed upstream. This is needed to support building Gerrit on Java 11 and newer Java versions. [1] https://github.com/bazelbuild/bazel/issues/9378 [2] https://github.com/google/error-prone/issues/1348 Change-Id: Ib1778629fef5e2f61891ff0a176e4b5c74f2aa8a
121 lines
4.5 KiB
Python
121 lines
4.5 KiB
Python
load(
|
|
"@bazel_tools//tools/jdk:default_java_toolchain.bzl",
|
|
"JDK9_JVM_OPTS",
|
|
"default_java_toolchain",
|
|
)
|
|
load("@rules_java//java:defs.bzl", "java_package_configuration")
|
|
load("@rules_python//python:defs.bzl", "py_binary")
|
|
|
|
exports_files(["nongoogle.bzl"])
|
|
|
|
py_binary(
|
|
name = "merge_jars",
|
|
srcs = ["merge_jars.py"],
|
|
main = "merge_jars.py",
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
default_java_toolchain(
|
|
name = "error_prone_warnings_toolchain",
|
|
bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"],
|
|
jvm_opts = JDK9_JVM_OPTS,
|
|
package_configuration = [
|
|
":error_prone",
|
|
],
|
|
visibility = ["//visibility:public"],
|
|
)
|
|
|
|
# Error Prone errors enabled by default; see ../.bazelrc for how this is
|
|
# enabled. This warnings list is originally based on:
|
|
# https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl
|
|
# However, feel free to add any additional errors. Thus far they have all been pretty useful.
|
|
# TODO(davido): Enable ImmutableAnnotationChecker again when these issues are fixed:
|
|
# https://github.com/google/error-prone/issues/1348
|
|
# https://github.com/bazelbuild/bazel/issues/9378
|
|
java_package_configuration(
|
|
name = "error_prone",
|
|
javacopts = [
|
|
"-XepDisableWarningsInGeneratedCode",
|
|
"-Xep:AmbiguousMethodReference:ERROR",
|
|
"-Xep:AutoValueFinalMethods:ERROR",
|
|
"-Xep:BadAnnotationImplementation:ERROR",
|
|
"-Xep:BadComparable:ERROR",
|
|
"-Xep:BoxedPrimitiveConstructor:ERROR",
|
|
"-Xep:CannotMockFinalClass:ERROR",
|
|
"-Xep:ClassCanBeStatic:ERROR",
|
|
"-Xep:ClassNewInstance:ERROR",
|
|
"-Xep:DateFormatConstant:ERROR",
|
|
"-Xep:DefaultCharset:ERROR",
|
|
"-Xep:DoubleCheckedLocking:ERROR",
|
|
"-Xep:ElementsCountedInLoop:ERROR",
|
|
"-Xep:EqualsHashCode:ERROR",
|
|
"-Xep:EqualsIncompatibleType:ERROR",
|
|
"-Xep:ExpectedExceptionChecker:ERROR",
|
|
"-Xep:Finally:ERROR",
|
|
"-Xep:FloatingPointLiteralPrecision:ERROR",
|
|
"-Xep:FragmentInjection:ERROR",
|
|
"-Xep:FragmentNotInstantiable:ERROR",
|
|
"-Xep:FunctionalInterfaceClash:ERROR",
|
|
"-Xep:FutureReturnValueIgnored:ERROR",
|
|
"-Xep:GetClassOnEnum:ERROR",
|
|
"-Xep:ImmutableAnnotationChecker:OFF",
|
|
"-Xep:ImmutableEnumChecker:ERROR",
|
|
"-Xep:IncompatibleModifiers:ERROR",
|
|
"-Xep:InjectOnConstructorOfAbstractClass:ERROR",
|
|
"-Xep:InputStreamSlowMultibyteRead:ERROR",
|
|
"-Xep:IterableAndIterator:ERROR",
|
|
"-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR",
|
|
"-Xep:JUnitAmbiguousTestClass:ERROR",
|
|
"-Xep:LiteralClassName:ERROR",
|
|
"-Xep:MissingCasesInEnumSwitch:ERROR",
|
|
"-Xep:MissingFail:ERROR",
|
|
"-Xep:MissingOverride:ERROR",
|
|
"-Xep:MutableConstantField:ERROR",
|
|
"-Xep:NarrowingCompoundAssignment:ERROR",
|
|
"-Xep:NonAtomicVolatileUpdate:ERROR",
|
|
"-Xep:NonOverridingEquals:ERROR",
|
|
"-Xep:NullableConstructor:ERROR",
|
|
"-Xep:NullablePrimitive:ERROR",
|
|
"-Xep:NullableVoid:ERROR",
|
|
"-Xep:OperatorPrecedence:ERROR",
|
|
"-Xep:OverridesGuiceInjectableMethod:ERROR",
|
|
"-Xep:PreconditionsInvalidPlaceholder:ERROR",
|
|
"-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR",
|
|
"-Xep:ProtocolBufferOrdinal:ERROR",
|
|
"-Xep:ReferenceEquality:ERROR",
|
|
"-Xep:RequiredModifiers:ERROR",
|
|
"-Xep:ShortCircuitBoolean:ERROR",
|
|
"-Xep:SimpleDateFormatConstant:ERROR",
|
|
"-Xep:StaticGuardedByInstance:ERROR",
|
|
"-Xep:StringEquality:ERROR",
|
|
"-Xep:SynchronizeOnNonFinalField:ERROR",
|
|
"-Xep:TruthConstantAsserts:ERROR",
|
|
"-Xep:TypeParameterShadowing:ERROR",
|
|
"-Xep:TypeParameterUnusedInFormals:ERROR",
|
|
"-Xep:URLEqualsHashCode:ERROR",
|
|
"-Xep:UnsynchronizedOverridesSynchronized:ERROR",
|
|
"-Xep:WaitNotInLoop:ERROR",
|
|
"-Xep:WildcardImport:ERROR",
|
|
],
|
|
packages = ["error_prone_packages"],
|
|
)
|
|
|
|
package_group(
|
|
name = "error_prone_packages",
|
|
packages = [
|
|
"//java/...",
|
|
"//javatests/...",
|
|
"//plugins/codemirror-editor/...",
|
|
"//plugins/commit-message-length-validator/...",
|
|
"//plugins/delete-project/...",
|
|
"//plugins/download-commands/...",
|
|
"//plugins/gitiles/...",
|
|
"//plugins/hooks/...",
|
|
"//plugins/plugin-manager/...",
|
|
"//plugins/replication/...",
|
|
"//plugins/reviewnotes/...",
|
|
"//plugins/singleusergroup/...",
|
|
"//plugins/webhooks/...",
|
|
],
|
|
)
|