4f10d777d9
As of M80(chrome version >= 80), chrome removed the native htmlImports support, tho we have the polyfill from webcomponents, the loading of html changed from sync to async which cause a lot test to fail in M80. The fix is introducing a util method `readyToTest` which wait until htmlImports finished before running any tests. Updated some tests to have only one top suite per test so we only need one `readyToTest` and also multiple `readyToTest` actually affect tests' stub functionality. Tested locally with `npm run test` on all passed tests and also with manual failure to make sure the updated tests can still catch any errors if have. Bug: Issue 12294 Change-Id: Ib0c464f8ff9f36a401e6c3b249e6bb6d68ee6e2f
96 lines
2.8 KiB
HTML
96 lines
2.8 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
@license
|
|
Copyright (C) 2018 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<title>gr-url-encoding-behavior</title>
|
|
|
|
<script src="/bower_components/webcomponentsjs/custom-elements-es5-adapter.js"></script>
|
|
|
|
<script src="/bower_components/webcomponentsjs/webcomponents-lite.js"></script>
|
|
<script src="/bower_components/web-component-tester/browser.js"></script>
|
|
<script src="../../test/test-pre-setup.js"></script>
|
|
<link rel="import" href="../../test/common-test-setup.html"/>
|
|
<link rel="import" href="gr-url-encoding-behavior.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<test-element></test-element>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-url-encoding-behavior tests', async () => {
|
|
await readyToTest();
|
|
let element;
|
|
let sandbox;
|
|
|
|
suiteSetup(() => {
|
|
// Define a Polymer element that uses this behavior.
|
|
Polymer({
|
|
is: 'test-element',
|
|
behaviors: [Gerrit.URLEncodingBehavior],
|
|
});
|
|
});
|
|
|
|
setup(() => {
|
|
sandbox = sinon.sandbox.create();
|
|
element = fixture('basic');
|
|
});
|
|
|
|
teardown(() => {
|
|
sandbox.restore();
|
|
});
|
|
|
|
suite('encodeURL', () => {
|
|
test('double encodes', () => {
|
|
assert.equal(element.encodeURL('abc?123'), 'abc%253F123');
|
|
assert.equal(element.encodeURL('def/ghi'), 'def%252Fghi');
|
|
assert.equal(element.encodeURL('jkl'), 'jkl');
|
|
assert.equal(element.encodeURL(''), '');
|
|
});
|
|
|
|
test('does not convert colons', () => {
|
|
assert.equal(element.encodeURL('mno:pqr'), 'mno:pqr');
|
|
});
|
|
|
|
test('converts spaces to +', () => {
|
|
assert.equal(element.encodeURL('words with spaces'), 'words+with+spaces');
|
|
});
|
|
|
|
test('does not convert slashes when configured', () => {
|
|
assert.equal(element.encodeURL('stu/vwx', true), 'stu/vwx');
|
|
});
|
|
|
|
test('does not convert slashes when configured', () => {
|
|
assert.equal(element.encodeURL('stu/vwx', true), 'stu/vwx');
|
|
});
|
|
});
|
|
|
|
suite('singleDecodeUrl', () => {
|
|
test('single decodes', () => {
|
|
assert.equal(element.singleDecodeURL('abc%3Fdef'), 'abc?def');
|
|
});
|
|
|
|
test('converts + to space', () => {
|
|
assert.equal(element.singleDecodeURL('ghi+jkl'), 'ghi jkl');
|
|
});
|
|
});
|
|
});
|
|
</script>
|