
Previously in Polygerrit, diff views were always displayed in the width specified in diff preferences. This change gives the option to wrap lines instead, which takes precedence over column width (the column width option is hidden when line wrapping is selected), and fits the diff view to screen. The gerrit API already supports the 'lineWrapping' preference so this change uses that already existing option. Feature: Issue 4809 Change-Id: I0d9e292739b5910abfd04af63ec4c745bf06e446
105 lines
3.6 KiB
JavaScript
105 lines
3.6 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the 'License');
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an 'AS IS' BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function(window, GrDiffBuilder) {
|
|
'use strict';
|
|
|
|
// Prevent redefinition.
|
|
if (window.GrDiffBuilderSideBySide) { return; }
|
|
|
|
function GrDiffBuilderSideBySide(diff, comments, prefs, outputEl, layers) {
|
|
GrDiffBuilder.call(this, diff, comments, prefs, outputEl, layers);
|
|
}
|
|
GrDiffBuilderSideBySide.prototype = Object.create(GrDiffBuilder.prototype);
|
|
GrDiffBuilderSideBySide.prototype.constructor = GrDiffBuilderSideBySide;
|
|
|
|
GrDiffBuilderSideBySide.prototype.buildSectionElement = function(group) {
|
|
var sectionEl = this._createElement('tbody', 'section');
|
|
sectionEl.classList.add(group.type);
|
|
var pairs = group.getSideBySidePairs();
|
|
for (var i = 0; i < pairs.length; i++) {
|
|
sectionEl.appendChild(this._createRow(sectionEl, pairs[i].left,
|
|
pairs[i].right));
|
|
}
|
|
return sectionEl;
|
|
};
|
|
|
|
GrDiffBuilderSideBySide.prototype.addColumns = function(outputEl, fontSize) {
|
|
var width = fontSize * 4;
|
|
var colgroup = document.createElement('colgroup');
|
|
|
|
// Add left-side line number.
|
|
var col = document.createElement('col');
|
|
col.setAttribute('width', width);
|
|
colgroup.appendChild(col);
|
|
|
|
// Add left-side content.
|
|
colgroup.appendChild(document.createElement('col'));
|
|
|
|
// Add right-side line number.
|
|
col = document.createElement('col');
|
|
col.setAttribute('width', width);
|
|
colgroup.appendChild(col);
|
|
|
|
// Add right-side content.
|
|
colgroup.appendChild(document.createElement('col'));
|
|
|
|
outputEl.appendChild(colgroup);
|
|
};
|
|
|
|
GrDiffBuilderSideBySide.prototype._createRow = function(section, leftLine,
|
|
rightLine) {
|
|
var row = this._createElement('tr');
|
|
row.classList.add('diff-row', 'side-by-side');
|
|
row.setAttribute('left-type', leftLine.type);
|
|
row.setAttribute('right-type', rightLine.type);
|
|
|
|
this._appendPair(section, row, leftLine, leftLine.beforeNumber,
|
|
GrDiffBuilder.Side.LEFT);
|
|
this._appendPair(section, row, rightLine, rightLine.afterNumber,
|
|
GrDiffBuilder.Side.RIGHT);
|
|
return row;
|
|
};
|
|
|
|
GrDiffBuilderSideBySide.prototype._appendPair = function(section, row, line,
|
|
lineNumber, side) {
|
|
var lineEl = this._createLineEl(line, lineNumber, line.type, side);
|
|
lineEl.classList.add(side);
|
|
row.appendChild(lineEl);
|
|
var action = this._createContextControl(section, line);
|
|
if (action) {
|
|
row.appendChild(action);
|
|
} else {
|
|
var textEl = this._createTextEl(line, side);
|
|
var threadEl = this._commentThreadForLine(line, side);
|
|
if (threadEl) {
|
|
textEl.appendChild(threadEl);
|
|
}
|
|
row.appendChild(textEl);
|
|
}
|
|
};
|
|
|
|
GrDiffBuilderSideBySide.prototype._getNextContentOnSide = function(
|
|
content, side) {
|
|
var tr = content.parentElement.parentElement;
|
|
while (tr = tr.nextSibling) {
|
|
content = tr.querySelector(
|
|
'td.content .contentText[data-side="' + side + '"]');
|
|
if (content) { return content; }
|
|
}
|
|
return null;
|
|
};
|
|
|
|
window.GrDiffBuilderSideBySide = GrDiffBuilderSideBySide;
|
|
})(window, GrDiffBuilder);
|