gerrit/gerrit-acceptance-tests
Logan Hanks ea3e3b704a Downgrade default notify for WIP reviews
Sometimes reviews are posted to a change while it's in the WIP state.
The owner may be preparing guidance for their upcoming reviewers, or a
CI bot may be reporting about tests. In general, for the purpose of
filtering messages, we distinguish between bot and human actions on the
basis of whether a tag is provided. A non-null tag is assumed to
indicate automation.

For reviews posted by humans, the default notify level depends on
whether hasReviewStarted is true for the change. If a new WIP change is
created and pending reviewers are added, those reviewers should never
receive an email about the change until the owner starts review.
Therefore, when WIP is true, hasReviewStarted is false, and tag is
null, the default notify level is downgraded from ALL to OWNER. If the
change has started review, the default notify level continues to be ALL
(only if tag is null).

For reviews posted by bots, the default notify level is downgraded for
all WIP changes, even after they've entered review. For example, a CI
bot may post failing test results for a series of intermediate patch
sets. This is just noise to reviewers, but useful to the owner, so when
WIP is true and tag is non-null, the default notify level is downgraded
to OWNER.

Change-Id: I93395e36470090377d2120bb8136e7c11670d224
2017-06-14 14:17:25 -07:00
..
src/test Downgrade default notify for WIP reviews 2017-06-14 14:17:25 -07:00
BUILD Move prolog:common rule to gerrit-server root build file 2017-05-18 06:17:11 +02:00
tests.bzl Don't ship bouncycastle libraries in plugin API 2017-04-07 07:38:04 +02:00