76aaa8cb33
In some cases, the "press c to comment" feature was overriding default browser copy behavior. This change checks for modifiers before creating comments. This functionality is factored out into a function for future use. Bug: Issue 3989 Change-Id: I3ebe0dec2f5436b8339d81d99d1287799ff3568b
99 lines
2.5 KiB
JavaScript
99 lines
2.5 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-selection-action-box',
|
|
|
|
/**
|
|
* Fired when the comment creation action was taken (hotkey, click).
|
|
*
|
|
* @event create-comment
|
|
*/
|
|
|
|
properties: {
|
|
keyEventTarget: {
|
|
type: Object,
|
|
value: function() { return document.body; },
|
|
},
|
|
range: {
|
|
type: Object,
|
|
value: {
|
|
startLine: NaN,
|
|
startChar: NaN,
|
|
endLine: NaN,
|
|
endChar: NaN,
|
|
},
|
|
},
|
|
side: {
|
|
type: String,
|
|
value: '',
|
|
},
|
|
},
|
|
|
|
behaviors: [
|
|
Gerrit.KeyboardShortcutBehavior,
|
|
],
|
|
|
|
listeners: {
|
|
'tap': '_handleTap',
|
|
},
|
|
|
|
placeAbove: function(el) {
|
|
var rect = this._getTargetBoundingRect(el);
|
|
var boxRect = this.getBoundingClientRect();
|
|
var parentRect = this.parentElement.getBoundingClientRect();
|
|
this.style.top =
|
|
rect.top - parentRect.top - boxRect.height - 4 + 'px';
|
|
this.style.left =
|
|
rect.left - parentRect.left + (rect.width - boxRect.width) / 2 + 'px';
|
|
},
|
|
|
|
_getTargetBoundingRect: function(el) {
|
|
var rect;
|
|
if (el instanceof Text) {
|
|
var range = document.createRange();
|
|
range.selectNode(el);
|
|
rect = range.getBoundingClientRect();
|
|
range.detach();
|
|
} else {
|
|
rect = el.getBoundingClientRect();
|
|
}
|
|
return rect;
|
|
},
|
|
|
|
_checkForModifiers: function(e) {
|
|
return e.altKey || e.ctrlKey || e.metaKey || e.shiftKey || false;
|
|
},
|
|
|
|
_handleKey: function(e) {
|
|
if (this.shouldSupressKeyboardShortcut(e)) { return; }
|
|
if (e.keyCode === 67) { // 'c'
|
|
if (this._checkForModifiers(e)) { return; }
|
|
e.preventDefault();
|
|
this._fireCreateComment();
|
|
}
|
|
},
|
|
|
|
_handleTap: function() {
|
|
this._fireCreateComment();
|
|
},
|
|
|
|
_fireCreateComment: function() {
|
|
this.fire('create-comment', {side: this.side, range: this.range});
|
|
},
|
|
});
|
|
})();
|