Go to file
Stefan Beller ef00a864d1 Submit: Disable submit button when change is unmergable.
A user reported internally:
> It used to be the case that the submit button was greyed out if your
> repo required fast-forward and your CL was out of date.  Now there's
> no obvious way to tell if a submit is likely to succeed without trying
> it, which is a minor but daily annoyance.

This may have been introduced with the `submitWholeTopic` feature recently.
Looking at the code I suspect that there was a client side check for
enabling the submit button as well as there is a client side class
com.google.gerrit.client.changes.ChangeInfo.MergeableInfo.

Part of the `submitWholeTopic` feature was moving responsibility more to
the server and dumb down the client a bit. So now we also have to do this
computation at the server side.

Change-Id: I5dcd8c954446462660d45ead13eb38b6d8fa822a
Signed-off-by: Stefan Beller <sbeller@google.com>
2015-03-17 11:51:21 +09:00
2014-12-18 11:16:03 +09:00
2015-03-16 09:25:46 -07:00
2013-11-30 01:53:00 -08:00
2015-03-13 11:50:26 +09:00
2015-03-04 10:59:02 +09:00
2015-03-04 10:59:02 +09:00
2015-03-07 23:03:15 +01:00
2015-03-03 07:12:16 +00:00
2013-11-09 07:45:00 +01:00
2015-01-23 17:56:02 +09:00
2015-03-04 10:59:02 +09:00
2008-11-14 16:59:34 -08:00
2009-03-27 20:20:10 -07:00
2015-02-23 02:53:20 +00:00
Description
RETIRED, Gerrit as used by OpenStack
120 MiB