* Update plugins/replication from branch 'master'
to 5622267e9fe339e185c6e80978b57100476d8f25
- Remove unused private methods
Change-Id: Ibad18b68f471bfb2e6fadaf1455993aa2d382d9d
- Get a URI lock before running tasks.
This allows more than one related gerrit process (as in multi-master
situations) to access the persistent task store at the same time without
deleting each other's task files. This also prevents more than one gerrit
process from pushing to the same URI at the same time.
Change-Id: I1f3f4d60605ff21038e722553cb38494e18b9ff9
- Create persistent task files safely
Use a temporary directory to create the files in first to avoid
partially written files being exposed in the waiting directory.
Change-Id: I82222e16b52926ced304cb24eadd1c8d56cf9a7a
- Fix potential loss of persisted replication task
There was a race window between the check to see if any new updates were
available for the completed update and the deletion of the persistent
update. If an update occurred in that window it could leave the event
missing from the persisted task store. If the server went down before
this update completed, the update would be missed entirely.
Eliminate the race by separating the running tasks from the waiting
tasks in the persistent store by placing each into their own
subdirectories. Place new waiting tasks in a "waiting" directory and
move them to the "running" directory once they are running. This allows
new updates to be persisted to the "waiting" directory while a similar
update is running without the waiting task getting deleted when the
persisted running task is deleted. On startup, reset all running tasks
by moving them back to the waiting directory to ensure that they are
retried.
Reset "running" tasks (return them to the "waiting" directory) when a
retry is rescheduled, this allows the retry to be consolidated with the
new run, and helps ensure that the persistence store reflects what is
actually happening better.
Bug: Issue 11672
Change-Id: Ia31329e8d939f8e5cb1e7455de69744431f34d66
4f889cba0d