Go to file
Dave Borowitz ef40918fb4 Use ObjectId instead of RevId in PatchSet, and remove RevId
RevId began its existence in I43a6d6e4:

  Introduce RevId as an abstraction around revision strings

  This may make it easier to replace Git with some other tool like
  Hg or SVN, but it also offers us a convenient way to abstract the
  data type and improve type safety within Gerrit's code tree.

There are no plans to support another VCS in Gerrit in the foreseeable
future; that would be a huge project. Even if we were to start, moving
away from ObjectId in the storage layer is just a drop in the ocean,
considering the heavy usage of ObjectId elsewhere in Gerrit (to say
nothing of other JGit APIs).

The arguments around encapsulating the type and improving compile-time
safety still apply, but ObjectId serves the same purposes--arguably
better, since ObjectId has useful and well-tested and -benchmarked
methods upstream in JGit.

There were other arguments for using RevId in the past: ObjectId
couldn't be used as a field type in ReviewDb, and isn't GWT-compatible.
These arguments no longer hold, since both ReviewDb and GWT are gone.

The specific implementation of RevId itself had some shortcomings:

 * It didn't validate that the underlying value was a valid hex SHA-1.
 * It allowed null as a value, although nearly all callers assumed it
   didn't.
 * The id field was non-final. (In practice it was not possible to
   reassign it without using either gwtorm libraries or direct
   reflection.)
 * There were no convenient methods for converting to/from ObjectId,
   a very frequent operation, largely because of the historical GWT
   incompatibility.

Of course, these problems are fixable, but why bother? ObjectId serves
the purpose, and this way contributors don't have the cognitive overhead
of deciding which of two similar types to use.

Change-Id: Iff5644e21c51a7a8c12a113fd5a6a6ffaf60ae20
2019-04-29 07:42:11 -07:00
2019-04-19 16:07:45 +09:00
2019-04-27 11:58:42 +09:00
2019-04-25 18:26:22 +01:00
2019-04-22 18:01:29 -07:00
2019-04-26 09:37:58 +09:00
2018-08-10 15:55:52 +01:00
2019-01-23 11:21:14 +00:00
2019-03-07 17:37:02 +09:00
2019-01-21 14:53:00 +09:00
2008-11-14 16:59:34 -08:00
2009-03-27 20:20:10 -07:00
2019-04-26 09:37:58 +09:00
2019-04-27 11:58:42 +09:00

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.

Description
RETIRED, Gerrit as used by OpenStack
Readme 120 MiB