Dave Borowitz f55bd4feac Labels: Fix NPE on merged change with no approvals
The Labels widget includes a list of votable label for each reviewer on
the change. Prior to I3a40f9d9, the list of reviewers was computed from
the labels list in the ChangeInfo. ReceiveCommits#markChangeMergedByPush
closes the change but does not stamp any labels at submit time, the
result being an empty label list, which in turn means an empty
reviewer list on a change that was marked merge by push. (That is not
optimal, but is not the problem we're solving here.)

After I3a40f9d9, the reviewer list is computed differently, so we may
have a non-empty reviewer list even though the label list is empty.
The empty label list is also used to build a map of account ID -> set
of votable labels. Since the label list is empty, that map is now
empty, so the VotableInfo returned from looking up a reviewer in that
map is null.

Check for null, avoiding an NPE in the client.

Change-Id: I511d4e6505ba8948bac52660b34ddfa2ca668947
2016-02-07 15:10:12 -05:00
2016-02-01 16:26:41 +01:00
2015-12-17 13:25:02 -05:00
2016-02-01 17:49:33 +09:00
2015-12-22 11:40:29 +09:00
2016-01-28 03:12:05 +00:00
2015-12-18 07:35:37 +01:00
2016-01-28 03:12:05 +00:00
2015-03-03 07:12:16 +00:00
2015-12-02 14:07:12 +00:00
2013-11-09 07:45:00 +01:00
2015-04-08 07:50:41 +00:00
2008-11-14 16:59:34 -08:00
2009-03-27 20:20:10 -07:00
2016-01-07 21:29:47 +01:00
2015-11-09 21:44:27 +00:00

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.

Events

  • March 14-18 2016: Gerrit Hackathon, Berlin (free seats are still available).
Description
RETIRED, Gerrit as used by OpenStack
Readme 120 MiB