opendev/gerrit
Code Issues Proposed changes
Files
f6b479a5337e014dae90a9420a4853a5d4fa2ded
gerrit/Documentation
History
Khai Do f6b479a533 Fix inconsistent notifications on vote removal 
Change Ie4f05fafb73a implemented a feature to allow direct removal
of a vote from the Gerrit UI.  Clicking reply on the Gerrit UI and
setting the vote to 0 is essentially the same thing as clicking
'X' on the vote.  The difference is that Gerrit will fire a
comment-added event on the reply however it will not fire
an event when users remove the vote by clicking the 'X'.
This is inconsistent behavior.  This change attempts to fix this
inconsistent behavior by also sending a comment-added event when
users click on the 'X' to remove a vote.

The vote removal appear as the following comment:
"Zaro Removed Code-Review-2 by Russell Westbrook <rwestbrook@localhost.com>"

Email preview: http://paste.openstack.org/show/485472

Bug: issue 3701
Change-Id: I279cb5b411d8c8e37243a5d3b734a8f002523d97
2016-03-21 19:40:59 -07:00
..
images
Documentation: Use "link" icon from Silk Icons for anchor image
2016-02-12 11:52:36 +09:00
.gitignore
Ignore /Documentation/*.html
2015-05-06 11:25:51 -07:00
access-control.txt
Add caveat that the minimum expansion of RE must be a valid ref
2016-03-20 07:38:36 +00:00
asciidoc.defs
Pack prettify.min.{js,css} into documentation.
2015-06-26 03:04:09 +00:00
BUCK
Vulcanize PolyGerrit in Buck build
2015-11-18 15:26:39 -05:00
cmd-apropos.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-ban-commit.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-cherry-pick.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-close-connection.txt
Add command to close SSH connection
2015-01-19 09:54:55 -05:00
cmd-create-account.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-create-branch.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-create-group.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-create-project.txt
Remove deprecated --name option from create project SSH command
2015-07-21 15:42:04 +02:00
cmd-flush-caches.txt
Add a Maintain Server global capability
2015-06-12 11:15:57 -04:00
cmd-gc.txt
Add "aggressive" option to ssh command "GC"
2015-03-19 15:45:29 +01:00
cmd-gsql.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-hook-commit-msg.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-index-activate.txt
Support generic indexes in LuceneVersionManager
2016-03-20 10:29:58 +01:00
cmd-index-start.txt
Support generic indexes in LuceneVersionManager
2016-03-20 10:29:58 +01:00
cmd-index.txt
doc: fix link to cmd-index-activate.html page
2016-02-26 00:17:50 +00:00
cmd-kill.txt
Revert "== GERRIT" in documentation.
2014-03-25 19:44:49 +00:00
cmd-logging-ls-level.txt
Add SSH to configure logging level at runtime
2014-09-26 09:13:35 -04:00
cmd-logging-set-level.txt
Add SSH to configure logging level at runtime
2014-09-26 09:13:35 -04:00
cmd-ls-groups.txt
Remove documentation of --type option from ls-groups command
2016-01-21 05:56:27 +00:00
cmd-ls-members.txt
Documentation: Format fix headlines
2014-03-24 18:32:42 -07:00
cmd-ls-projects.txt
Change ls-project default type option from 'code' to 'all'
2016-03-02 15:20:58 -05:00
cmd-ls-user-refs.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-plugin-enable.txt
Documentation update for cmd-plugin
2015-01-21 11:03:08 +09:00
cmd-plugin-install.txt
Documentation update for cmd-plugin
2015-01-21 11:03:08 +09:00
cmd-plugin-ls.txt
Correct documentation of required capabilities for listing plugins
2015-04-30 00:58:28 +00:00
cmd-plugin-reload.txt
Documentation update for cmd-plugin
2015-01-21 11:03:08 +09:00
cmd-plugin-remove.txt
Documentation update for cmd-plugin
2015-01-21 11:03:08 +09:00
cmd-query.txt
Terminate sortkey with prejudice
2014-12-23 14:48:06 -08:00
cmd-receive-pack.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-rename-group.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-review.txt
Add the --strict-labels option to SSH review command
2015-12-17 14:46:22 +09:00
cmd-set-account.txt
Fix minor typo in set-account command documentation
2015-05-12 05:03:16 +00:00
cmd-set-head.txt
Update set-head ssh command documentation
2015-03-05 09:50:10 +01:00
cmd-set-members.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-set-project-parent.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-set-project.txt
Fix inconsistency in documentation
2014-05-07 14:51:17 +02:00
cmd-set-reviewers.txt
SetReviewersCommand: Use ChangeUtil#findChanges
2015-11-20 14:11:10 -05:00
cmd-show-caches.txt
Add a Maintain Server global capability
2015-06-12 11:15:57 -04:00
cmd-show-connections.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-show-queue.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-stream-events.txt
Use subscribe pattern to avoid eager stream-events materialization
2016-01-07 08:12:21 +01:00
cmd-suexec.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-test-submit-rule.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-test-submit-type.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
cmd-version.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
config-auto-site-initialization.txt
Control which plugins will be auto installed on auto init
2014-02-24 11:11:04 +01:00
config-cla.txt
Remove contact store functionality
2015-08-28 14:08:58 -04:00
config-gerrit.txt
Merge "LFS protocol support"
2016-03-18 12:59:32 +00:00
config-gitweb.txt
Document gitweb URL set, cgi unset configuration
2015-06-22 11:09:31 -07:00
config-hooks.txt
Append approval info to every comment-added stream event and hook
2016-03-18 14:47:36 +01:00
config-labels.txt
config-gerrit: Fix typos in copyAllScoresOnMergeCommitFirstParentUpdate anchor
2016-03-01 00:14:28 +00:00
config-login-register.txt
Add '-T' switch to the SSH connectivity check examples
2016-01-29 14:00:52 +01:00
config-mail.txt
Fix inconsistent notifications on vote removal
2016-03-21 19:40:59 -07:00
config-plugins.txt
Add emoticons plugin to plugin documentation
2015-12-28 10:40:05 +01:00
config-project-config.txt
Add project config boolean to require signed push on a project
2015-10-21 09:09:20 -04:00
config-reverseproxy.txt
Update reverse proxy configuration example for nginx
2015-07-06 01:50:38 +00:00
config-sso.txt
OpenID: Remove support for Google Accounts
2015-03-01 22:25:50 +01:00
config-themes.txt
Remove deprecated gerrit_addHistoryHook(f) JavaScript function
2015-07-21 16:02:44 +02:00
config-validation.txt
Added OutgoingEmailValidationListener
2015-01-06 09:02:39 +01:00
config.defs
Pack prettify.min.{js,css} into documentation.
2015-06-26 03:04:09 +00:00
database-setup.txt
Add support for SAP HANA
2016-01-28 14:07:17 +01:00
dev-buck.txt
project.py: always download sources
2016-02-24 01:29:58 +00:00
dev-build-plugins.txt
Add HOWTO documentation about building of plugins
2014-01-24 23:16:25 +01:00
dev-contributing.txt
Change "bracket" to "brace" in the style guide in dev-contributing.txt
2016-03-11 03:58:22 -05:00
dev-design.txt
Update out of date hyperlinks
2015-06-17 22:38:13 +00:00
dev-eclipse.txt
Dev doc: Document the maxCompiledUnitsAtOnce setting in Eclipse
2015-08-28 10:31:47 +09:00
dev-inspector.txt
Fix various spelling mistakes
2015-05-19 15:05:26 +09:00
dev-plugins.txt
Merge "LFS protocol support"
2016-03-18 12:59:32 +00:00
dev-readme.txt
Update buck to the latest version
2015-10-09 08:51:35 +02:00
dev-release-deploy-config.txt
Document how to deploy a JGit release to Google Cloud Storage
2016-02-18 15:47:12 +01:00
dev-release-jgit.txt
Document how to deploy a JGit release to Google Cloud Storage
2016-02-18 15:47:12 +01:00
dev-release-subproject.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
dev-release.txt
dev-release: Update steps to upload documentation
2016-03-11 09:40:25 +00:00
dev-rest-api.txt
Make Content-Type examples consistent with actual server output
2015-01-06 06:54:12 +00:00
doc.css.in
Tweak doc css to avoid overlapping with search box
2015-09-16 23:29:20 -07:00
error-branch-not-found.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-change-closed.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-change-does-not-belong-to-project.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-change-not-found.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-change-upload-blocked.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-commit-already-exists.txt
Merge branch 'stable-2.8'
2014-03-11 18:24:13 +09:00
error-contains-banned-commit.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-has-duplicates.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-invalid-author.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-invalid-changeid-line.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-invalid-committer.txt
Fix reference to Forge Committer access right in documentation
2014-07-08 07:24:01 +00:00
error-messages.txt
Remove "no changes made" error case
2016-02-09 10:05:58 -05:00
error-missing-changeid.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
error-missing-subject.txt
Improve reject message if Change-Id is in subject
2014-02-21 09:25:33 +01:00
error-multiple-changeid-lines.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-no-common-ancestry.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-no-new-changes.txt
Update no-new-change error message documentation
2015-10-09 14:58:49 +00:00
error-non-fast-forward.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-a-gerrit-administrator.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-allowed-to-upload-merges.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-permitted-to-create.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-signed-off-by.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-not-valid-ref.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-permission-denied.txt
Add '-T' switch to the SSH connectivity check examples
2016-01-29 14:00:52 +01:00
error-prohibited-by-gerrit.txt
Work around asciidoctor handling of nested ` and *
2015-04-06 17:22:37 +09:00
error-project-not-found.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
error-push-fails-due-to-commit-message.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
error-squash-commits-first.txt
Minor improvements in the 'squash commits first' error documentation
2014-09-05 09:25:33 +09:00
error-upload-denied.txt
Added searchbox to documentation.
2013-11-05 12:49:43 -08:00
gen_licenses.py
Bump Closure Compiler version to v20151216
2016-01-05 17:38:12 -05:00
i18n-readme.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
index.txt
Document how to deploy a JGit release to Google Cloud Storage
2016-02-18 15:47:12 +01:00
install-j2ee.txt
Fix broken formatting in Tomcat reverse proxy config documentation
2014-10-21 11:04:42 +09:00
install-quick.txt
Correct docs since --name is not a valid option for create-project
2015-11-25 00:27:32 +00:00
install.txt
Offer downloads through https://www.gerritcodereview.com/download/
2015-06-12 19:07:37 -07:00
intro-project-owner.txt
Use consistent lowercase for "gitweb"
2015-06-12 13:24:46 -04:00
intro-quick.txt
Consistently refer to Change-Id in documentation
2014-09-04 13:12:24 +09:00
intro-user.txt
Update the documentation of the user preferences
2016-03-16 16:38:18 +01:00
js-api.txt
Add JavaScript extension point for comments
2016-01-08 18:55:26 +00:00
json.txt
Append approval info to every comment-added stream event and hook
2016-03-18 14:47:36 +01:00
license.defs
gen_licenses.py: Use buck query for license generation
2015-11-12 18:40:30 -05:00
pgm-daemon.txt
Allow to use --enable-httpd with --slave
2014-10-30 11:02:24 -04:00
pgm-gsql.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
pgm-index.txt
Add documentation for SecureStore
2015-02-23 09:53:05 +01:00
pgm-init.txt
Option to skip library download during init
2016-02-11 13:39:30 +00:00
pgm-LocalUsernamesToLowerCase.txt
Doc: Consistently refer to "Web UI" rather than "WebUI"
2014-05-02 17:21:22 +09:00
pgm-prolog-shell.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
pgm-reindex.txt
Reindex: Remove --output option
2016-03-17 13:13:48 +01:00
pgm-rulec.txt
Use the new section title style in Asciidoctor.
2013-12-20 12:55:51 -08:00
pgm-SwitchSecureStore.txt
Add documentation for SecureStore
2015-02-23 09:53:05 +01:00
project-configuration.txt
Merge branch 'stable-2.11'
2015-05-04 16:44:45 +02:00
prolog-change-facts.txt
Add Prolog predicate for the uploader of the patch set
2016-01-28 15:12:41 +01:00
prolog-cookbook.txt
Documentation: Correct spelling of rules.enable setting
2016-02-29 13:57:23 -08:00
replace_macros.py
tools: use python on path
2015-06-18 17:10:11 +02:00
rest-api-access.txt
Make Content-Type examples consistent with actual server output
2015-01-06 06:54:12 +00:00
rest-api-accounts.txt
Make adding of signed-off-by footer for online changes customizable
2016-02-19 22:46:28 +09:00
rest-api-changes.txt
SubmitInput: Remove deprecated waitForMerge field
2016-03-10 15:00:20 +00:00
rest-api-config.txt
Merge doc and change searches.
2015-11-24 22:14:39 -08:00
rest-api-documentation.txt
Don't limit tables to 50% width in REST API documentation
2014-11-25 18:35:53 +09:00
rest-api-groups.txt
ListGroups: Allow -s as an alias of --suggest
2016-02-18 14:21:20 +09:00
rest-api-plugins.txt
Make Content-Type examples consistent with actual server output
2015-01-06 06:54:12 +00:00
rest-api-projects.txt
Merge "New option to schedule the Git garbage collection as a background task"
2016-01-07 04:28:37 +00:00
rest-api.txt
Consistently format HTTP response codes in REST API documentation
2015-01-21 11:42:32 +09:00
user-change-cleanup.txt
Add background job to abandon inactive changes automatically
2015-06-25 07:26:25 +02:00
user-changeid.txt
Work around asciidoctor handling of nested ` and *
2015-04-06 17:22:37 +09:00
user-dashboards.txt
Add user guide
2015-04-30 14:37:09 +00:00
user-inline-edit.txt
Merge branch 'stable-2.11'
2015-10-27 11:10:42 +09:00
user-named-destinations.txt
Add named destinations support
2015-09-03 10:50:07 -06:00
user-named-queries.txt
Move 'User Refs' docs to the intro-user doc.
2015-09-04 14:55:15 +00:00
user-notify.txt
Clarify notification scheme on watched projects
2014-12-12 13:46:38 -06:00
user-review-ui.txt
Merge branch 'stable-2.12'
2016-03-10 15:22:46 +09:00
user-search.txt
Documentation: remove submitted status from user search and review
2016-03-08 04:52:30 +00:00
user-signedoffby.txt
Revert "== GERRIT" in documentation.
2014-03-25 19:44:49 +00:00
user-submodules.txt
SubmoduleOp: Have a flag for verbosity of superproject messages
2015-07-20 09:19:23 -07:00
user-upload.txt
doc: Clarify "Submit" permission on "refs/for/<ref>"
2016-03-15 14:00:31 +00:00