Files
gerrit/polygerrit-ui/app/elements/shared/gr-linked-text/gr-linked-text.js
Becky Siegel 423f298512 Fix for autolinking missing matches
Previously, there was an issue where text would not get autolinked if
there were multiple regex patterns and a match for one was found below
the occurance of another that was not checked for yet.  This change
addresses the issue by checking the full text block for matches for each
type of regex, regardless if one has been found above it.

Bug: Issue 4325
Change-Id: I11db954de6a1da26b8ab29b8501b1f1f01425364
2016-11-02 20:42:26 -07:00

69 lines
1.9 KiB
JavaScript

// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
(function() {
'use strict';
Polymer({
is: 'gr-linked-text',
properties: {
content: {
type: String,
observer: '_contentChanged',
},
pre: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
disabled: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
config: Object,
},
observers: [
'_contentOrConfigChanged(content, config)',
],
_contentChanged: function(content) {
// In the case where the config may not be set (perhaps due to the
// request for it still being in flight), set the content anyway to
// prevent waiting on the config to display the text.
if (this.config != null) { return; }
this.$.output.textContent = content;
},
_contentOrConfigChanged: function(content, config) {
var output = Polymer.dom(this.$.output);
output.textContent = '';
var parser = new GrLinkTextParser(
config, function(text, href, fragment) {
if (href) {
var a = document.createElement('a');
a.href = href;
a.textContent = text;
a.target = '_blank';
output.appendChild(a);
} else if (fragment) {
output.appendChild(fragment);
}
});
parser.parse(content);
},
});
})();