opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
14,285 Commits 1 Branch 360 Tags 120 MiB
fe1a9138fa
Go to file
Simon Hwang fe1a9138fa Fix Incorrect owner group matching behaviour for creating projects 
This change fixes a critical bug that might add a wrong group as an
owner of a project being created by ssh commands.

Before this fix, when the --owner argument does not match any group, the
commands tried to find a group whose name starts with the argument
instead of throwing an error to notify the user.

This behaviour seemed to be insecure and this fix prevents the commands
to create the project and throws an error if the --owner argument is not
valid, that is, if there is no exact match for the group name.

In total, the ssh commands that are affected by this change are:
CreateGroupCommand, CreateProjectCommand, ListGroupsCommand, and
SetMembersCommand. Moreover, it makes more sense to use exactSuggestion
instead of bestSuggestion for those commands as well.

Bug: Issue 3655
Change-Id: Icec00651b4268a2b70799f1cba739db5248b04f5
2015-11-09 09:55:01 -05:00
.settings RFC: Enable Eclipse warning about fall-through cases in switch statements 2015-02-03 12:17:49 +09:00
bucklets Rename __standalone_mode__ to STANDALONE_MODE 2014-11-24 08:44:12 +00:00
contrib Fix minor python code style issues 2014-12-18 02:51:06 +00:00
Documentation Inline edit: Strip trailing blank lines from commit messages 2015-10-26 08:18:05 +00:00
gerrit-acceptance-tests Fix Incorrect owner group matching behaviour for creating projects 2015-11-09 09:55:01 -05:00
gerrit-antlr Support change~branch~id in query syntax 2014-12-10 09:55:08 -08:00
gerrit-cache-h2 H2: Don't show stack trace when failing to build BloomFilter 2015-04-28 07:43:29 +00:00
gerrit-common Submit: Fix ClassCastException for anonymous user 2015-10-14 00:54:55 +02:00
gerrit-extension-api Set version to 2.11.4 2015-10-13 20:57:17 +09:00
gerrit-gwtdebug Organize imports 2014-12-18 11:16:03 +09:00
gerrit-gwtexpui Tweak JS clipboard API integration to work on Firefox 2015-10-24 20:28:32 +02:00
gerrit-gwtui Inline edit: Strip trailing blank lines from commit messages 2015-10-26 08:18:05 +00:00
gerrit-gwtui-common Remove unused "remove reviewer" image 2015-01-08 18:39:58 +09:00
gerrit-httpd Submit: Fix ClassCastException for anonymous user 2015-10-14 00:54:55 +02:00
gerrit-launcher Fix some warnings raised by CheckStyle 2015-02-12 19:38:30 +09:00
gerrit-lucene Bind OnlineReindexer.Factory in LuceneIndexModule 2015-07-13 12:31:42 +09:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-oauth Merge branch 'stable-2.10' into stable-2.11 2015-05-07 10:37:48 +09:00
gerrit-openid Merge branch 'stable-2.10' into stable-2.11 2015-05-07 10:37:48 +09:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-pgm Include server config module in init step 2015-10-22 13:25:07 +00:00
gerrit-plugin-api Set version to 2.11.4 2015-10-13 20:57:17 +09:00
gerrit-plugin-archetype Set version to 2.11.4 2015-10-13 20:57:17 +09:00
gerrit-plugin-gwt-archetype Set version to 2.11.4 2015-10-13 20:57:17 +09:00
gerrit-plugin-gwtui Set version to 2.11.4 2015-10-13 20:57:17 +09:00
gerrit-plugin-js-archetype Set version to 2.11.4 2015-10-13 20:57:17 +09:00
gerrit-prettify Pack prettify.min.{js,css} into documentation. 2015-06-26 03:04:09 +00:00
gerrit-reviewdb Move edit ref name methods from ChangeEditUtil to RefNames 2015-04-16 19:17:29 +09:00
gerrit-server Fix Incorrect owner group matching behaviour for creating projects 2015-11-09 09:55:01 -05:00
gerrit-solr Add index configuration to specify maximum possible limit 2015-01-20 11:04:08 -08:00
gerrit-sshd Add username to stream-events queue entries 2015-10-31 20:44:23 +09:00
gerrit-util-cli Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-util-http Refactor RequestUtil into a separate package 2014-10-30 15:35:26 -07:00
gerrit-util-ssl Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-war Set version to 2.11.4 2015-10-13 20:57:17 +09:00
lib Replace vanilla parboiled with grappa library 2015-07-28 11:51:20 +09:00
plugins Set correct revision of cookbook plugin 2015-10-30 11:29:26 +09:00
ReleaseNotes Update 2.11.4 release notes 2015-10-15 13:21:55 +09:00
tools Remove org.json:json and fix gwt-dev deps 2015-06-26 06:29:43 +00:00
website/releases Releases: Update website to use Cloud Storage v1 API 2014-11-21 12:22:59 -08:00
.buckconfig Add buck build soyc to output GWT split point report 2015-01-15 04:40:28 +00:00
.buckversion Update buck version to same as master 2015-04-14 14:47:50 +09:00
.gitignore Add '/.apt_generated' and '/.factorypath' to .gitignore 2015-04-29 13:56:33 +02:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.mailmap Update mailmap 2015-01-23 17:56:02 +09:00
.pydevproject Update PyDev project to use Python 2.7 2014-10-02 15:16:44 +09:00
.watchmanconfig Watchman: Add buck-out dir to ignored directories 2014-08-21 07:32:37 +02:00
BUCK Update Buck and use gwt_binary() 2014-05-19 11:41:31 -07:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Set version to 2.11.4 2015-10-13 20:57:17 +09:00