opendev/gerritlib
Code Issues Proposed changes

fix param ordering to fix review function

Browse Source 
the change id needs to come before the args, otherwise it can't
parse the change id.

Change-Id: I2d83fa3000cd4739f0d8ec5524aa3ca2391506de
This commit is contained in:
Sean Dague 2013-09-23 07:58:31 -04:00
parent 139c168bb3
commit d16c93bece
1 changed files with 1 additions and 2 deletions

3
gerritlib/gerrit.py

@ -133,7 +133,7 @@ class Gerrit(object):
return out.split('\n')
def review(self, project, change, message, action={}):
cmd = 'gerrit review --project %s' % project
cmd = 'gerrit review %s --project %s' % (change, project)
if message:
cmd += ' --message "%s"' % message
for k, v in action.items():
@ -141,7 +141,6 @@ class Gerrit(object):
cmd += ' --%s' % k
else:
cmd += ' --%s %s' % (k, v)
cmd += ' %s' % change
out, err = self._ssh(cmd)
return err