opendev/git-restack
Code Issues Proposed changes

Provide usage help even if not in Git directory

Browse Source 
If a new user installs git-review and invokes it with no arguments (or with
'-h' / '--help') outside of a Git working tree, all she gets is a terse error
message that offers no usage help.

With this change, git-review behaves in the following manner when invoked
outside a git working tree:

* If a command-line argument is present and it is not '-h' or '--help', it is
  assumed that the user was attempting some action, and so git-review fails
  with the same error message as before.
* If no command-line arguments are present, or if there is a single
  command-line argument that is either '-h' or '--help', usage information is
  printed and the program exits.

This patch also adds myself to AUTHORS and fixes a small typo in README.rst.

Change-Id: I6fda72bf5311e74318b42e2860e7742e07b515de
This commit is contained in:
Ori Livneh
2013-05-28 10:37:03 -07:00
parent 267b8a8e4d
commit 068b659da2
3 changed files with 20 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README.rst
View File

@@ -130,4 +130,4 @@ Use ``git review`` to submit patches (after creating a gerrit account that links
# Do your commits
git review
# Enter your username if promped
# Enter your username if prompted