opendev/git-restack
Code Issues Proposed changes

Add workaround for broken urlparse.

Browse Source 
Fixes bug 905010. urlparse on Python 2.6.1 on OSX can't parse the ssh urls
properly. So we special case commando it if the parse failure follows the
way that the broken urlparse will mis-parse the string.

Change-Id: I1a550fce77e596d2529436e4024792e9c86d2e4e
This commit is contained in:
Monty Taylor
2011-12-21 09:17:25 +00:00
parent 7d6213e134
commit 2545e433bf
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
git-review
View File

@@ -207,6 +207,11 @@ def split_hostname(fetch_url):
hostname = parsed_url.netloc hostname = parsed_url.netloc
port = 22 port = 22
# Workaround bug in urlparse on OSX
if parsed_url.scheme == "ssh" and hostname[:2] == "//":
hostname = hostname[2:]
hostname = hostname.split("/")[0]
if "@" in hostname: if "@" in hostname:
(username, hostname) = hostname.split("@") (username, hostname) = hostname.split("@")
if ":" in hostname: if ":" in hostname: