From d97ffdd964f9cb53fee71053f551c08b895a4e27 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Mon, 26 Dec 2011 09:05:41 -0800 Subject: [PATCH] Only pass plain strings to shlex.split. According to http://bugs.python.org/issue6988 some versions of shlex.split can't handle unicode input, always producing ucs-4 output. This addresses that problem, which is present for me in oneiric. Change-Id: I6d22825e2accfb4ff395d2a2f9efdb20fc413073 --- git-review | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-review b/git-review index b300edb..4c4d211 100755 --- a/git-review +++ b/git-review @@ -46,7 +46,7 @@ _has_color = None def run_command(cmd, status=False, env={}): if VERBOSE: print "Running:", cmd - cmd_list = shlex.split(cmd) + cmd_list = shlex.split(str(cmd)) newenv = os.environ newenv.update(env) p = subprocess.Popen(cmd_list, stdout=subprocess.PIPE,