From e2bd0f5f3c3a94786efa8688a054233fc63dd215 Mon Sep 17 00:00:00 2001 From: Darragh Bailey Date: Tue, 4 Nov 2014 16:17:34 +0000 Subject: [PATCH] Use 'no_proxy' env variable in addition to uppercase Need to override both variations of the no_proxy environment variable since some tools do not check for the other if one is already defined. While 'no_proxy' appears to be now the most common convention, it is safer to set both lower and upper case to the same value when running unit tests. Change-Id: I536b6f2711ac70e0a2a45676098fb461ab3b8d33 --- git_review/tests/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git_review/tests/__init__.py b/git_review/tests/__init__.py index b945170..dfb71fe 100644 --- a/git_review/tests/__init__.py +++ b/git_review/tests/__init__.py @@ -167,7 +167,7 @@ class BaseGitReviewTestCase(testtools.TestCase, GerritHelpers): '--name', 'test/test_project') # ensure user proxy conf doesn't interfere with tests - os.environ['NO_PROXY'] = '*' + os.environ['no_proxy'] = os.environ['NO_PROXY'] = '*' # prepare repository for the testing self._run_git('clone', self.project_uri)