Cloning via http in tests will break if the user has proxy settings
enabled that don't explicitly exclude the IP address range being used by
the local gerrit instances spun up to test against.
Change-Id: Ic33b72198a85a063d1818f4b318cde2f57e1b1be
Also add some log during tests preparation.
This patch will redownload gerrit.war unless you rename it:
mv .gerrit/gerrit.war .gerrit/gerrit-2.8.5.war
Change-Id: I0f0a6cf7cfb70778d47a0fcbf1f09c5d292cd425
If we launch 'git branch' when we are detached from HEAD and if the
locale is set to English (LANG=C), we will have:
* (detached from head)
master
(...)
Then the topic will be '(detached': not so pretty and incorrect
according to Yuriy Taraday;
Also, it's maybe better to use a copy of 'os.environ' to only add
environment variables for this single command and not for all next
commands which will be launched in this processus.
PS: added a new test to check if this new feature works correctly
PS2: 'git checkout --detach' has been introduced in git 1.7.5. It's
maybe better to use 'git checkout BRANCH^0' instead.
PS3: handle the case where $LANG is not defined and correctly add this
environment variable
Change-Id: I8bc74c5ed28de08038e07cfd37efbaf1c4f4e78f
Note: this change modifies .gerrit content (used by tests), so delete
.gerrit folder and run "python -m git_review.tests.prepare".
Change-Id: Ia12d7148e3127ed5e10da449f1f4eebe633262bd
--help was being parsed specially to allow it to work out of Git tree.
This change shifts responsibility for that back to argparse module.
It also allows --version to run outside Git tree.
Change-Id: I88b7572d3dfc6a61d82bad55b2b3b5ecec908784
git-review crashes when using it with Python 2 (the default one in
Ubuntu 14.04): https://bugs.launchpad.net/git-review/+bug/1308050
It seems that in the main() method, 'cmd' can contain utf-8 chars:
git-review find '(détachée' (french word for 'detached') as topic.
This utf-8 string has caused a crash.
I guess we should always have an utf-8 string from a git command
but because I'm not so sure about that and I let you review this :-)
As advised by Clark Boylan, it can be interesting to encode the string
in run_command_status() method.
It's just needed to 'encode' it when we have an unicode string (python
2). shlex.split needs a 'str', not an 'unicode' type with utf-8 chars,
not a 'bytes' type and not not a 'bytes' type converted to 'str' (with
Python 3):
>>> shlex.split(str("echo héhé".encode('utf-8')))
['becho h\\xc3\\xa9h\\xc3\\xa9']
PS: Fixed error when launching tests with Python 2.6
PS2: Used 'sys.version_info' instead of 'sys.version'
(thanks to Alex Gaynor)
Change-Id: Ie5bed46e562d3f9f2df54abe8b0fd6e849583df7
When detecting color support, git-review attempts to decode to unicode
the git log output. Whenever a commit message has invalid unicode, an
exception is thrown:
File "git_review/cmd.py", line 366, in check_color_support
(status, output) = run_command_status(test_command)
File "git_review/cmd.py", line 130, in run_command_status
out = out.decode('utf-8')
File "python/2.7.6/encodings/utf_8.py", line 16, in decode
return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xa0 in position
197283: invalid start byte
Happens with https://github.com/composer/composer/commit/737fe32f4db
which contains \xA0. Simply ask unicode decoder to replace the invalid
bytes with U+FFFD REPLACEMENT CHARACTER.
Change-Id: I041d1a9aab6fe00ad807407747c6263d577fba17
Git review should not provide a default port when no port is defined
in the ssh remote url and delegates the choice to ssh config file (
git behavior).
Change-Id: I933a5715863d052c4760f26d6827f5296d426483
Closes-Bug: #1075751
It allows to use git review -d/-m/-x/-N/-X over http(s) and allows
to enable/disable ssl certificate check using http.sslVerify git
option or GIT_SSL_NO_VERIFY environment variable.
Note: it requires REST API support on gerrit side.
Change-Id: Ic0bd846607c62c5403a3393dcbccbcec432bd51d
Closes-Bug: #1290268
The current manual page contains hyphens where a minus sign
was intended. By default, "-" chars are interpreted as
hyphens (U+2010) by groff, not as minus signs (U+002D).
Since options to programs use minus signs (U+002D), this
means for example in UTF-8 locales that you cannot cut and
paste options, nor search for them easily.
This patch fixes this by escaping hyphens with backslashes.
Change-Id: I66e8041366ced24dac2ac21bbcf49de67a63c75b
If a subcommand's output includes a non-ASCII character, the following
occurs:
[nova]$ LANG=zh_CN.UTF-8 LC_ALL=zh_CN.UTF-8 git review --setup
Traceback (most recent call last):
File "/usr/bin/git-review", line 1187, in <module>
print(e)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 180-183: ordinal not in range(128)
Python3 works, because we force-encode everyting in run_command_status.
Change-Id: Ic4f4b0df57068c356a670901e02bf00c33985e2c
Hard set testr concurrency to 2 so that fewer gerrit instances are
started in parallel compared to the default testr concurrency setting.
This will help avoid contention for memory and process resources when
running the tests.
Change-Id: Id3837500ce243af8d8ef762c6dcf50146876f406
set_hooks_commit_msg used scp to download commit_msg hook even for
gerrit http(s) remote url. It will use scp for ssh remote url and
http(s) download for http(s) remote url (more proxy "friendly").
Note: this change modifies .gerrit/golden_site folder content (used
by tests), so delete .gerrit folder and run
"python -m git_review.tests.prepare".
Closes-bug: #1274876
Change-Id: I49bcf4fd84a88878f9381ddf1a8714b778688a0a
git-review tried to parse the output of "git remote show -n" to
retrieve a remote's pushurl and failed if the user's locale was not
English. This change reads the configuration directly instead.
Change-Id: Idbf98ae00538dd611277ca862da969f22cbe6265
Closes-Bug: #1177429
For every test number N run in process with PID, we take address
127.N.PID/256.PID%256 and let Gerrit listen on its default ports (29418
for SSH and 8080 for HTTP) on that address. We also name site dir with
the same address with "site-" prefix.
Thanks to Clark Boylan for this great idea.
Change-Id: I95b010e7a5b96c981614d5d3401efe861534806f
* tox.ini: The LANG, LANGUAGE and LC_ALL environment overrides were
introduced originally during the testr migration in an attempt to be
conservative about the possibility that locale settings in the
calling environment could cause consistency problems for test runs.
In actuality, this should be unnecessary and any place where it does
cause issues ought to be considered an actual bug. Also, having
these in the configuration actively causes older pip to have
problems with non-ASCII content in some package metadata files under
Python 3, so drop it now.
Change-Id: I8747a52141321549c56214710b70c5838aacc84e
Closes-Bug: #1277495
The regex did not support the use of a `:` and a `#` in the bug
identification line. The updated regex now will support bug
identification lines that look like `Closes-Bug: #12345`.
Co-Authored-By: Nicolas Simonds <nic@metacloud.com>
Change-Id: Ie5edd9a04fe714302f06b2df2c4c134a2ef2316a
If some test hangs by some reason, we get 1h delay in the gate until
Jenkins kills the job. This will shorten the delay to ~15min tops.
Change-Id: I8c6533aecd8b72b6c904c8e1724a0b27ff943d5b
The offset between test gerrit ssh/http ports was the same as the
offset between test gerrit sites (1000): 1st test gerrit site http
port was the same as 2nd test gerrit site ssh port
Change-Id: I9c9ca05cd2a966773d72aeb210cc88a35daa9b62
.Fl includes a dash for free when listing command line options, so
replace a typo of ---compare with --compare in the manual page.
Change-Id: Icaa6d87e954ebba75d534ed96f3632d80077f762
