411 Commits

Author SHA1 Message Date
James E. Blair
da19131702 Change draft ref to drafts.
Between 2.3-rc0 and 2.3, Gerrit changed the magic drafts
ref to 'drafts'.

Change-Id: I6608633ad55c977d371ea24f76d3b19f5481c568
2012-04-11 13:19:25 -07:00
Jenkins
b895fab2f3 Merge "Retrieve project & team name from fetch url" 2012-04-08 00:30:29 +00:00
James E. Blair
4eaa3bb3c0 Fix scope error with configParser.
Fixes bug 974461.

Change-Id: Ic3e6bc91355dc1df9f14a69f5493ed5dcc497f92
2012-04-06 08:38:24 -07:00
Darragh Bailey
ff57cd775c Retrieve project & team name from fetch url
Change to use urlparse to extract the path which
corresponds to the project name in gerrit. And improve
how the team name is extracted.

Previously if fed:

ssh://dbailey-k@review.openstack.org:29418/openstack-ci/git-review.git

parse_git_show returned:

(review.openstack.org, None, dbailey-k, 29418, git-review)

Instead of:

(review.openstack.org, openstack-ci, dbailey-k, 29418, openstack-ci/git-review)

Change-Id: Ib945c4c0b93623e524c0f536cb4059762eca301e
2012-04-06 16:28:24 +01:00
Antoine Musso
ffccbf2783 minor glitches in manpage
* Update document date
* 'change' argument was not showing up correctly
* whitepsaces removal
* end sentences with a dot. <--
* Fix some part which where not showing up

Change-Id: I20ceb0ee2831639c2b02e9eb9da8c61f8de187ab
2012-04-04 13:22:23 +02:00
Monty Taylor
8264557a8e More resilient downloading.
Apparently, python 2.7.3 does split("\n") differently which meant
that the first element was empty.

Change-Id: I0b34f8d161eba0dc5549df311719222691620c65
2012-04-02 13:23:43 -07:00
saper
c65e742b9b Override remote options: update manpage
Add description of defaultremote and defaultreview
options in .gitreview
Add -r remote option to -s synopsis
Updated to match master as of 415fbcbc7faef3d0f7dfa16f12ab3f0f3da0041c

Change-Id: Id64c56863de9fec4016ce42e1686d29b1ee094ba
2012-04-01 13:06:27 +02:00
Jenkins
415fbcbc7f Merge "Allow the user to override remote consequently" 2012-03-31 22:49:24 +00:00
saper
29f2a25b61 Reformat manpage to mdoc(7)
* Use more modern structural markup for the manpage
* Remove macros and comments left by rst2man
* Provide clues on typical use in synopsis
* Small changes to wording
* Reorder options
* Add Antoine and myself as an author

Change-Id: Ic2bd35b4a4a8ebcbf3e8e4e07d485fa6b6c6349b
2012-04-01 00:15:07 +02:00
saper
76b9b8695d Allow the user to override remote consequently
Now "-r" can be added every time to provide
new remote to use. During setup this remote
will be created (insted of "gerrit").

Add two .gitreview options:
* defaultremote (default: "gerrit")
  remote name to use when no -r specified
* defaultrebase (default: true)
  if false, assume -R (no rebase - bug 949422 and others)

Fix problems signalled by pep8

Change-Id: I75e5e7b1bdaffb0fbb1a40c690f10bae4b4be20a
2012-03-28 16:43:59 +02:00
Jenkins
b6717a5e99 Merge "bump year references from 2011 to 2012" 2012-03-28 03:46:45 +00:00
Antoine Musso
0263d69a9e enhance man page
* a bit longer option description
* describe the .ini file
* some very basic examples

Patchset2: various typos and improper english.
Patchset3: three more typos

Thanks to Roan Kattouw for the proof reading.

Change-Id: I2fa74fe2ede8568919929db34ca0b9dee28c6541
2012-03-27 21:43:55 +02:00
Antoine Musso
58dbdfe046 bump year references from 2011 to 2012
Change-Id: I2a9e0f192ae7421e12b19b15e3bed8fd22fb5a34
2012-03-27 15:50:38 +02:00
James E. Blair
4fead107ca Start development on 1.16
Change-Id: Id17e18369a374d638244aaf9bfe3968d436fc8a2
2012-02-29 12:06:25 -08:00
Monty Taylor
f719a31954 Actually fix the urlparse bug in OSX.
On OSX, if fed this:

ssh://mordred@review.openstack.org:29418/openstack-ci/git-review.git

urlparse returns this:

ParseResult(scheme='ssh', netloc='',
path='//mordred@review.openstack.org:29418/openstack-ci/git-review.git',
params='', query='', fragment='')

Instead of

ParseResult(scheme='ssh', netloc='mordred@review.openstack.org:29418',
path='/openstack-ci/git-review.git', params='', query='', fragment='')

Change-Id: I003e2f809df8d7dc92ecb8bfb4f772f09f6dc8ee
2012-02-09 20:22:03 -08:00
Monty Taylor
e0e1b87138 Start dev on 1.15.
Change-Id: Ia76b202f3d202321a8345f41753213d886e338db
2012-02-09 17:37:31 -08:00
Monty Taylor
21ae3f3d1e Fix an obvious breakage on OSX.
Change-Id: Ie4dec475d91477b0c3a96d72372c42748916992d
2012-02-09 16:09:28 -08:00
Monty Taylor
32047ab92a Start dev on 1.14.
Change-Id: I34764f6bb95f3b55c30f6a71726d69a459a2555c
2012-02-09 14:05:07 -08:00
Monty Taylor
350909c915 Workaround for OSX urlparse issue.
Change-Id: Ib3a237f27dd2bc80570a07601f7ad3e42358195a
2012-02-09 13:59:14 -08:00
Michael Still
19955a536e Include timing info in verbose output
Change-Id: Ifc38d7dc2dd7ed56c1e515438e9391545e8685b0
2012-02-03 10:25:05 +11:00
Monty Taylor
c07da92ad1 Remove automagic requirements.txt.
This works, but for git-review it's actually just extra
overhead, rather than being helpful.

Change-Id: Ic39855ae7bb9ce47afe5db2f5ecc2dac2f36b73b
2012-02-02 14:13:35 -05:00
James E. Blair
ff3d506aea Use dirname instead of basename.
Fixes bug 924639, creation of spurious empty commit-msg directories.

Change-Id: I1416f058d4fe4fba59a1469fa35098674f9e1ab7
2012-02-01 03:47:28 +00:00
Antoine Musso
3d6675958f accepts color.ui boolean values
To configure color, git accepts {auto,never,always} as well as the usual
boolean values {true,false}.

.gitconfig examples:

Always enable colors:
	[color]
		ui = true

Never use colors:
	[color]
		ui = false

Change-Id: I2c309ed8ef1c8b50d0ed283e813dbf64c57d7671
2012-01-31 16:28:27 +01:00
Monty Taylor
62e14dc762 Started 1.13.
Change-Id: I5ebe0967252a2c14b1e913ed9560810edd4ea1ce
2012-01-30 17:00:42 -05:00
Monty Taylor
e8529608fd Provide easy flag for disabling update check.
Change-Id: I63939c304e9c1c634bf12c7ca6109b19926d26a1
2012-01-27 15:52:07 -05:00
Monty Taylor
284871b691 Freeze requirements for sdist packages.
Use installed virtualenv to determine the list of actual
dependent versions tested.

Change-Id: Iff9781e97f32a318e357ae1d3305a74e2b3ba479
2012-01-27 15:37:44 -05:00
Monty Taylor
f8e5df11f4 Start 1.12.
Change-Id: I9dd1a5e43ccc94339020393e8400aa971b6f4cb7
2012-01-27 03:46:28 -05:00
Monty Taylor
fe4a5c827e Start 1.11.
Change-Id: Id905c3353f335ada9fd0fae688b8aea7af537939
2012-01-27 03:45:04 -05:00
Monty Taylor
3cf55f98ac Added tox support for testing pep8.
We'll process requirements.txt to install depends as needed.
Also include a hacking doc explaining what we expect.
Also, including argparse automatically breaks our automagic version
numbering, so import it in main() (slightly evil, but not terrible)

Change-Id: Ib3f65459fe2cd54ce531b7ae22935e24bd8f8920
2012-01-26 18:55:10 -05:00
Jenkins
0cbe5c8e91 Merge "Added dependencies in requirements.txt" 2012-01-26 23:19:44 +00:00
Diederik
06b45ccb5d Added dependencies in requirements.txt
Change-Id: I353d5ccaf0b83fc5f86f3c5664870ed7cc209bec
2012-01-26 22:24:33 +01:00
Catrope
49ed14c15b Add myself to AUTHORS
Change-Id: Ib528d64f6d4479cfa153ac059f09bb11b2cc04cd
2012-01-26 22:09:42 +01:00
Kiall Mac Innes
9850b4d630 Add support for Gerrit 2.2.2's "Draft" status
Change-Id: Ic5fd9a68641cb502711ff3f64ee4204bf5482571
2012-01-26 02:50:14 +00:00
Catrope
ca006c3a48 Remove useless username parameter from add_remote
Per review on 3275

Change-Id: Id62de897130cd64b2a83a26f0085618097b7c524
2012-01-24 01:46:56 +01:00
Catrope
fc2e03f7aa Make the default branch configurable
This adds the defaultbranch= option to the config file format, and makes
it the default for the BRANCH command line parameter.

Also removes duplication of the dict with default values

(Amended to pass pep8)

Change-Id: I0fae7ca3a7662fccd491f84a7a3a009480b1c39c
2012-01-24 01:41:38 +01:00
Catrope
48c6f5a7a7 Break out the config reading into its own method
This uses a dict to store the values and passes it around where needed

(Amended to pass pep8)

Change-Id: I498498e83c92a05742d2a7a8d44aff4452ee32b2
2012-01-24 01:38:08 +01:00
Catrope
360156f152 Don't hardcode 'master'
Was hardcoded in:
* checking whether fetching is set up for the remote
* checking whether the topic of a downloaded change is bogus

(amended to pass pep8)

Change-Id: If9a4cd5c76829d69f1b3ee871a25966e5aaaa126
2012-01-24 01:33:04 +01:00
Catrope
6628889d81 Fix typo (Ammending -> Amending)
Change-Id: I018e70cc610531dded4a7da98f9754a6d53c3c3b
2012-01-22 07:59:14 +01:00
James E. Blair
d74e4054e7 Switch from 'git show' to 'git log'.
When searching for a topic, use 'git log' instead of 'git show'.
Git show prints the diff, which may include comments that match
the topic regexes.  We should really only be looking at the commit
messages, so use 'git log' instead.

Change-Id: I188b1f324b5c584317fd61227c176987a51d087e
2012-01-09 15:57:38 -08:00
Monty Taylor
405d6cc3fb Migrate to argparse. optparse is deprecated.
Change-Id: Id82cfbefae4613e16eb2a602267fdacb8a1afa56
2012-01-07 16:36:45 -08:00
Jason Axelson
a154a78dcd Make readme links clickable
Change-Id: I290bd57d9ac34ec4d6622d3c33d7e0f7c67da7fa
2012-01-04 20:11:25 -10:00
Jason Axelson
a12099853c Add installation instructions to readme
Change-Id: Iad062d42ec5509ea56755b6336f408fbb89db552
2012-01-04 20:11:21 -10:00
Jason Axelson
ca50853542 Clarify instructions for contributing
Also makes gerrit link clickable

Change-Id: I3eed4696776999bff6c96552ff530fcc06c2b135
2012-01-04 20:11:16 -10:00
Jason Axelson
3b4a225224 Add .gitreview instructions to readme
Change-Id: If0f1e28606f360c64c540189c977723dfe7c5e66
2012-01-04 20:11:04 -10:00
Monty Taylor
6be0923902 Post 1.9 release version bump.
Change-Id: Ia1bc977216ea340632329c0d6d1ceb8ed1b1f761
2012-01-03 11:59:12 -08:00
Monty Taylor
a28af319a4 Remove commit --amend from hook installation.
Fixes bug 911362.

If you run git review -s in a fresh repo, there is no reason for us to
amend any commits to add a commit message.

If you run git review in a repo with a change but which has not been used
with gerrit before and we download the hook, then we do want to amend the
commit.

Change-Id: I29d3ec42ca086ecdfec6dd788f04e19649eacb24
2012-01-03 11:50:26 -08:00
Monty Taylor
2dceb4aa11 Bump version post release.
Change-Id: Ia11a13f8aa41b21e3b8e0bbeb8a72cf8b037e801
2011-12-26 16:11:06 -05:00
Monty Taylor
f8705af42b Prep for release of 1.8.
Change-Id: I969bbf1f4915a94d351cc4b04459346358a8d560
2011-12-26 16:07:51 -05:00
Monty Taylor
54a5ce0b77 Document the new command line options.
Change-Id: I1361138ec556a9dd51b60657ed0e487168b8df66
2011-12-26 15:56:45 -05:00
Jenkins
9d8f930181 Merge "Add --finish option to git-review." 2011-12-26 20:39:21 +00:00