This synchronizes requirements.txt, test-requirements.txt and
setup.py with the current state of the openstack/requirements
global-requirements.txt list. Also adds flake8 exclusions to tox.ini
for new hacking rules with which git-review does not yet comply.
Change-Id: I837ba57134bea16dd46c3f512bccd51cb39f76c8
For ease of future source code maintenance by OpenStack developers,
git-review is now adopting the same Python Build Reasonableness as
used by current OpenStack projects.
Closes-Bug: 1179007
Change-Id: I20427b51e84b90dcc1d870a547cdcc5240b4ff0e
In Fedora, /usr/man and /usr/local/man do not exist. So far, so good,
100% LSB compliant, etc. But in such case Jeremy's workaround tries
to install into /usr/man, so builds fail.
Suggestion: keep 'share/man' as the normal path and only invoke the
workaround when it's needed.
Ironically, if you look at Jeremy's original review patch 1, it worked
properly: it detected if something was symlinked and expanded those.
But then some kind of ridiculously involved problem with package
upgrades in Debian popped up and the condition was quietly inverted.
See https://review.openstack.org/15146
Bug: 1073766
Change-Id: I78c2d2a0456ac2aa921b4d0720634622569d145d
* setup.py: This works around bug 1073766, what appears to be an
upstream installer issue exposed by e7b8dc61. When attempting to
idempotently create the full destination path, it will fail cryptically
on any existing symlink it finds (expecting only real directories).
Change-Id: I1e502b86854fd6ac57974b579af48cd75d3e7752
- #!/usr/bin/python -> #!/usr/bin/env python
BSD OS use /usr/local/bin/python
- Man pages location is OS specific.
For example, this is /usr/local/man on FreeBSD
or /usr/share/man on Debian.
I checked several Python projects like Nose-devs,
it seems there is a consensus to use 'man/manN'.
Change-Id: I584c80c23b1fb9cfe77025d8c93ab9494a7b6cf0
We'll process requirements.txt to install depends as needed.
Also include a hacking doc explaining what we expect.
Also, including argparse automatically breaks our automagic version
numbering, so import it in main() (slightly evil, but not terrible)
Change-Id: Ib3f65459fe2cd54ce531b7ae22935e24bd8f8920
If we upload source tarballs to PyPI instead of eggs, then the man
pages actually work. However, this means that the installer has to
run setup.py. Using sphinx, while slighly nicer from a dev
perspective, means we have to then require that people installing
git-review also install sphinx, which is a bit overkill given the
size of the man page.
This change, and a change to the release process of not uploading
eggs to PyPI should finall get git review --help to work.
Change-Id: I29b07667127a9ec5c241b7e1fc5a3960dd2a6b63
