opendev/git-review
Code Issues Proposed changes

Better username detection for add_remote()

Browse Source 
Change-Id: Ia083ec9d5f19bff4944080559672b5947d4e43ee
This commit is contained in:
Sorin Sbarnea
2017-02-23 15:30:14 +00:00
parent 67dbbc2e59
commit 72175104dd
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
git_review/cmd.py
View File

@@ -20,6 +20,7 @@ limitations under the License."""
import argparse import argparse
import datetime import datetime
import getpass
import json import json
import os import os
import re import re
@@ -391,9 +392,7 @@ def add_remote(scheme, hostname, port, project, remote, usepushurl):
username = git_config_get_value("gitreview", "username") username = git_config_get_value("gitreview", "username")
if not username: if not username:
username = os.getenv("USERNAME") username = getpass.getuser()
if not username:
username = os.getenv("USER")
remote_url = make_remote_url(scheme, username, hostname, port, project) remote_url = make_remote_url(scheme, username, hostname, port, project)
if VERBOSE: if VERBOSE: