opendev/git-review
Code Issues Proposed changes

Merge "Fix submitting signed patches"

Browse Source
This commit is contained in:
Zuul 2022-04-18 18:36:34 +00:00 committed by Gerrit Code Review
commit 75561d1a72
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
git_review/cmd.py
View File

@ -984,8 +984,8 @@ def assert_one_change(remote, branch, yes, have_hook):
use_color = "--color=always" use_color = "--color=always"
else: else:
use_color = "--color=never" use_color = "--color=never"
cmd = ("git log %s --decorate --oneline HEAD --not --remotes=%s" % ( cmd = ("git log %s --decorate --oneline --no-show-signature "
use_color, remote)) "HEAD --not --remotes=%s" % (use_color, remote))
(status, output) = run_command_status(cmd) (status, output) = run_command_status(cmd)
if status != 0: if status != 0:
print("Had trouble running %s" % cmd) print("Had trouble running %s" % cmd)

10
releasenotes/notes/fix-show-signatures-5e9c12d43b7051f0.yaml Normal file
View File

@ -0,0 +1,10 @@
---
fixes:
- |
Git's log.ShowSignature option is now supported. Previously,
setting it would confuse git-review into thinking there were
twice as many changes to push.
upgrade:
- |
Git 2.10.0 or later is required as git-review now needs the
``--no-show-signature`` option for git-log.