opendev
/
git-review
Code Issues Proposed changes

Push with --no-follow-tags 

When the git configuration value push.followTags is set and a repo has
tags, git-review pushes are rejected:

    ! [remote rejected]   TAG -> TAG
       (cannot combine normal pushes and magic pushes)

This change ensures that git-review never pushes with followTags.

Change-Id: Ifbd13284b16bad1165e73d25b99f17344180d423
This commit is contained in:
Hannu Hartikainen 2019-03-29 10:47:12 +02:00
parent 853f3bffb3
commit 98cc896bc2
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
git_review/cmd.py
View File

@ -1643,7 +1643,8 @@ def _main():
if options.custom_script:
run_custom_script("draft")
cmd = "git push %s HEAD:refs/%s/%s" % (remote, ref, branch)
cmd = ("git push --no-follow-tags %s HEAD:refs/%s/%s" %
(remote, ref, branch))
push_options = []
if options.topic is not None:
topic = options.topic