opendev/git-review
Code Issues Proposed changes

Fix listing changes over SSH for 2.14

Browse Source 
The SSH query API changed from 2.13 to 2.14 from

{"number":"1", ...}

to

{"number":1, ...}

so we need to stringify everything in order to do len, encode etc. on
it.

Change-Id: I06bdd1b4b1181d00a27ce1e76f97baed8cde1284
Story: 2001095
This commit is contained in:
Christoph Settgast
2017-06-29 10:27:16 +02:00
committed by Simon Kuhnle
parent 089e8e64b1
commit b61f5b2ec9
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
git_review/cmd.py
View File

@@ -1028,7 +1028,7 @@ class ReviewsPrinter(object):
@property @property
def fields_width(self): def fields_width(self):
return [ return [
max(len(review[field]) for review in self.reviews) max(len(str(review[field])) for review in self.reviews)
for field in self.fields[:-1] for field in self.fields[:-1]
] + [1] ] + [1]

2
git_review/tests/test_unit.py
View File

@@ -66,7 +66,7 @@ class GitReviewConsole(testtools.TestCase, fixtures.TestWithFixtures):
'subject': 'A simple short subject', 'subject': 'A simple short subject',
'topic': 'simple-topic' 'topic': 'simple-topic'
}, { }, {
'number': '9877', 'number': 9877, # Starting with 2.14, numbers are sent as int
'branch': 'stable/codeword', 'branch': 'stable/codeword',
'subject': 'A longer and slightly more wordy subject' 'subject': 'A longer and slightly more wordy subject'
}, { }, {