From d3b91e326eaf4b8ac33a3b57d4462aa838cd67f0 Mon Sep 17 00:00:00 2001 From: Christian Berendt Date: Thu, 17 Jul 2014 09:38:20 +0200 Subject: [PATCH] Enabled hacking checks H305 and H307 * H305 imports not grouped correctly * H307 like imports should be grouped together Change-Id: Ia4b376a90fed830ceea4b91caa920ff38263df5e --- git_review/cmd.py | 6 +++--- tox.ini | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/git_review/cmd.py b/git_review/cmd.py index c0745b21..d717aaaf 100755 --- a/git_review/cmd.py +++ b/git_review/cmd.py @@ -18,16 +18,17 @@ implied. See the License for the specific language governing permissions and limitations under the License.""" +import argparse import datetime import json import os -import pkg_resources import re import shlex import subprocess import sys import textwrap +import pkg_resources import requests if sys.version < '3': @@ -40,6 +41,7 @@ if sys.version < '3': do_input = raw_input else: import configparser as ConfigParser + import urllib.parse import urllib.request urlencode = urllib.parse.urlencode @@ -1036,8 +1038,6 @@ def convert_bool(one_or_zero): def main(): usage = "git review [OPTIONS] ... [BRANCH]" - import argparse - class DownloadFlag(argparse.Action): """Additional option parsing: store value in 'dest', but at the same time set one of the flag options to True diff --git a/tox.ini b/tox.ini index e4e8384d..7fe1130c 100644 --- a/tox.ini +++ b/tox.ini @@ -23,6 +23,6 @@ commands = python setup.py sdist {posargs} commands = {posargs} [flake8] -ignore = E125,H202,H305,H307,H405,H904 +ignore = E125,H202,H405,H904 show-source = True exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build