diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index f125621a..cb0d1619 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -16,13 +16,9 @@ To get the latest code, see: https://git.openstack.org/cgit/openstack-infra/git- Bugs are handled at: https://storyboard.openstack.org/#!/project/719 -There is a mailing list at: http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra - Code reviews, as you might expect, are handled by gerrit at: https://review.openstack.org - -See http://wiki.openstack.org/GerritWorkflow for details. Pull -requests submitted through GitHub will be ignored. +Pull requests submitted through GitHub will be ignored. Use ``git review`` to submit patches (after creating a gerrit account that links to your launchpad account). Example:: @@ -30,3 +26,13 @@ that links to your launchpad account). Example:: # Do your commits git review # Enter your username if prompted + +The code review process is documented at +https://docs.openstack.org/infra/manual/developers.html If that process is +not enough to get reviewers' attention then try these (in that order): + +1. Use git log and git blame to find "who last touched the file" and add + them. Make sure they're still active on https://review.openstack.org +2. Ping the #openstack-infra IRC channel, see developers.html above. +3. As a last resort, mailing-list at: + http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra diff --git a/HACKING.rst b/HACKING.rst index e6ccb960..d18b9ca9 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -244,7 +244,10 @@ the tests that OpenStack CI systems run. Behind the scenes, tox is running `testr run --parallel`, but is set up such that you can supply any additional testr arguments that are needed to tox. For example, you can run: `tox -- --analyze-isolation` to cause tox to tell testr to add ---analyze-isolation to its argument list. +--analyze-isolation to its argument list. Arguments past ``--`` are passed +through to testr, for instance to run a single test:: + + tox -e py36 -- git_review.tests.test_unit.SomeClass.some_test It is also possible to run the tests inside of a virtual environment you have created, or it is possible that you have all of the dependencies