39 lines
2.0 KiB
Plaintext
39 lines
2.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "99a6e8aa_22756e40",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4146
|
|
},
|
|
"writtenOn": "2024-03-05T15:28:54Z",
|
|
"side": 1,
|
|
"message": "\u003e Where/how was this problem observed? We merged some changes a while back to increase the Gerrit version in our tests, maybe that addressed it?\n\nGerrit didn\u0027t support java 17 until like version 3.6 or 3.7. I suspect the problem is simply due to Gerrit requiring java 11 previously. If we want to run the tests with java 17 we should update the version of gerrit tested against.",
|
|
"revId": "57c61017cc1e96c2e15fb8d6011dcc944455ded7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d90f272d_4602ed69",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4146
|
|
},
|
|
"writtenOn": "2024-03-05T15:42:07Z",
|
|
"side": 1,
|
|
"message": "\u003e \u003e Where/how was this problem observed? We merged some changes a while back to increase the Gerrit version in our tests, maybe that addressed it?\n\u003e \n\u003e Gerrit didn\u0027t support java 17 until like version 3.6 or 3.7. I suspect the problem is simply due to Gerrit requiring java 11 previously. If we want to run the tests with java 17 we should update the version of gerrit tested against.\n\nhttps://www.gerritcodereview.com/3.6.html#release-highlights says 3.6 was the first release to support java 17. However, this doesn\u0027t work when paired with a mariadb/mysql database. I don\u0027t think this affects the git-review test setup though as that should be using h2.",
|
|
"parentUuid": "99a6e8aa_22756e40",
|
|
"revId": "57c61017cc1e96c2e15fb8d6011dcc944455ded7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |