b0bf084d66
git_credentials() was converting the stdin argument to bytes. However according to the Python3 documentation subprocess.communicate() expects a string when universal_newlines=True is passed to Popen. The symptom was that git review would fail in p.communicate(stdin) on line 156 with the message "'bytes' object has no attribute 'encode'". This was observed with Python version 3.6.9 when running git-review against a gerrit repo over https, where the repo requires username and password to authenticate. Change-Id: I0c0314c3f7b0eb631e72e4ac187a9d443a2bc82b
git-review
A git command for submitting branches to Gerrit
git-review is a tool that helps submitting git branches to gerrit for review.
- Free software: Apache license
- Documentation: http://docs.openstack.org/infra/git-review/
- Source: https://git.openstack.org/cgit/openstack-infra/git-review
- Bugs: https://storyboard.openstack.org/#!/project/opendev/git-review