opendev
/
infra-manual
Code Issues Proposed changes

Update "Code Review" for OpenDev 

Generalize content for OpenDev, mark OpenStack specifics as such.

Fix description of +A button.

Change-Id: I39db553fc29f94f7ec9bc7c90f715573f85d51d7
This commit is contained in:
Andreas Jaeger 2020-03-05 17:54:25 +01:00
parent 84916c7c8f
commit 0ecacdde0c
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
doc/source/developers.rst
View File

@ -775,16 +775,18 @@ comments in a review comment the inline comments are stored as Drafts
in your browser. Other reviewers can only see them after you have
submitted them as a comment on the patchset.
Any OpenStack developer may propose or comment on a change (including
voting +1/0/-1 on it). OpenStack project teams have a policy
requiring two positive reviews from core reviewers. A vote of +2 is
Any developer may propose or comment on a change (including
voting +1/0/-1 on it). A vote of +2 is
allowed from core reviewers, and should be used to indicate that
they are a core reviewer and are leaving a vote that should be
counted as such.
When a review has two +2 reviews and one of the core team believes it
Some OpenDev hosted projects, like many OpenStack project teams, have
a policy requiring two positive reviews from core reviewers.
When a review has enough +2 reviews and one of the core team believes it
is ready to be merged, he or she should leave a +1 vote in the
"Approved" category. You may do so by clicking the "Review" button
"Workflow" category. You may do so by clicking the "Review" button
again, with or without changing your code review vote and optionally
leaving a comment. When a +1 Approved review is received, Zuul will
run tests on the change, and if they pass, it will be merged.