opendev/infra-manual
Code Issues Proposed changes

Core revier: Add +-2, approval

Browse Source 
Add brief content for core reviewers.

Change-Id: I8848a186c140296c2a70242c1e16a2f28f6e9950
This commit is contained in:
Andreas Jaeger
2014-12-01 21:39:09 +01:00
parent 3fa91e496d
commit 29a0440b4c
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
doc/source/core.rst
View File

@@ -11,9 +11,25 @@ Maintaining the Core Group
+/-2 votes
==========
Only core reviewers can give +2 and -2 votes. A vote of +2 indicates
that the core reviewer agrees that the patch can merge as is.
A vote of -2 blocks a patch completely, it should only be given in
exceptional cases. For example, if a patch is approved and currently
in the gate pipeline, a -2 will block it from merging.
Note that -2 votes are the only votes that are not reset when a new
patch gets uploaded. The core reviewer that gave a -2 is the only
person that can remove it again.
Approval
========
Once a patch has two +2 votes and neither any -2 votes or a Work in
Progress tag set, it is ready to be merged. Any core reviewer can
approve such a patch. A core reviewer can give a +2 and approval in
the same review.
Re-approval
===========