opendev/infra-manual
Code Issues Proposed changes

Clarify re-approval behaviour

Browse Source 
Clarify re-approval and recheck relationship.

Change-Id: Idda058417c542e6a0ad5e521fb65097727f48cf8
This commit is contained in:
Andreas Jaeger 2014-12-04 20:33:37 +01:00
parent 023b38c20f
commit 49959986de
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/source/core.rst
View File

@ -63,8 +63,11 @@ current change, re-approval.
Core reviewers can approve changes again to trigger gate testing for
that particular change. Core reviewers should still heed the advice in
:ref:`automated-testing` to ensure that unrelated failures are properly
tracked.
:ref:`automated-testing` to ensure that unrelated failures are
properly tracked. Note that the change will directly enter the gate
pipeline if and only if it has already a +1 vote from Jenkins,
otherwise it will first enter the check pipeline like a "recheck"
would.
When re-approving, core reviewers may need to work around a specific set
of Gerrit behavior. Gerrit only emits vote values in its event stream